Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to add custom number of Connectors for Nodes? #67

Open
rahul-codeb opened this issue Aug 17, 2021 · 8 comments
Open

Is it possible to add custom number of Connectors for Nodes? #67

rahul-codeb opened this issue Aug 17, 2021 · 8 comments
Labels
enhancement good first issue

Comments

@rahul-codeb
Copy link

@rahul-codeb rahul-codeb commented Aug 17, 2021

Hi, I'm finding difficulty to manage custom number of connectors to the nodes. Right now, Diagram-Maker Nodes only support (one input and one output).

Also, please let us know, if it is possible to create custom-standard nodes in diagram maker.

@rahul-codeb rahul-codeb added the enhancement label Aug 17, 2021
@occhangg
Copy link
Contributor

@occhangg occhangg commented Aug 17, 2021

Apologies for the delay in our response and thank you for reaching out.

Could you please expand more on your use case?

@rahul-codeb
Copy link
Author

@rahul-codeb rahul-codeb commented Aug 18, 2021

I want to implement custom number to Left-Right-Rectangular Node, and the connector behaviour should be completely configurable (Dropzone / Draggable).

Expectations :
image

Please, let me know if this is possible, and if possible please provide a demo code.

Thanks.

@occhangg occhangg pinned this issue Aug 18, 2021
@NorbertNader
Copy link

@NorbertNader NorbertNader commented Aug 25, 2021

Hey @notsonoobiee we currently do not have plans to support adding multiple node inputs/outputs. Would you be willing to contribute a code change to support this?

@NorbertNader NorbertNader unpinned this issue Aug 26, 2021
@NorbertNader NorbertNader added the good first issue label Aug 26, 2021
@nkev
Copy link

@nkev nkev commented Feb 1, 2022

@NorbertNader I don't understand why you would not even plan adding multiple inputs/outputs to nodes.

It's the most basic functionality and the first thing anyone is going to ask for when building something a little more complex than a single input and output, right?

@sameergoyal
Copy link
Contributor

@sameergoyal sameergoyal commented Feb 10, 2022

You can add multiple inputs & outputs already by just adding the right data attributes. See the relevant documentation around it: https://awslabs.github.io/diagram-maker/usage/declarative.html#customizing-the-node-connectors.

However, what's currently not possible is for edges to start & end at these "custom" connectors. That feature would need to be added.

@ktsao565
Copy link

@ktsao565 ktsao565 commented Feb 21, 2022

I'm going to try and give this a shot and submit a PR.

@diehbria
Copy link
Contributor

@diehbria diehbria commented Feb 21, 2022

@nkev I would like to clarify, there is no plans for the maintainers to actively create this feature, not that we would not accept this feature as a contribution. We would be happy to accept this feature. We are in communications with another user of this library, @tsao565 who is interested in implementing this. Stay tuned :-)

@nkev
Copy link

@nkev nkev commented Feb 22, 2022

Thanks @diehbria but I have since moved on to using drawflow, which better suits my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue
Projects
None yet
Development

No branches or pull requests

7 participants