expression: fix wrong caseWhen function for enum type (#29454)#29510
Merged
ti-chi-bot merged 2 commits intopingcap:release-5.1from Jan 27, 2022
Merged
expression: fix wrong caseWhen function for enum type (#29454)#29510ti-chi-bot merged 2 commits intopingcap:release-5.1from
ti-chi-bot merged 2 commits intopingcap:release-5.1from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Member
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Contributor
Author
|
/run-all-tests |
12 tasks
Contributor
Author
|
@wshwsh12 you're already a collaborator in bot's repo. |
lzmhhh123
approved these changes
Jan 25, 2022
Contributor
|
lgtm |
ichn-hu
approved these changes
Jan 25, 2022
Contributor
|
/merge |
Member
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 46046c9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #29454 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/29510After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #29357
Problem Summary:
What is changed and how it works?
There are two problem in this issue:
Problem 1:
Problem 2:
BuildCastFunction is useless. See constant_fold.goL129. We should have the same behavior for all args.
Check List
Tests
Side effects
Documentation
Release note