Skip to content

expression: fix wrong caseWhen function for enum type (#29454)#29510

Merged
ti-chi-bot merged 2 commits intopingcap:release-5.1from
ti-srebot:release-5.1-ae65cae8d04c
Jan 27, 2022
Merged

expression: fix wrong caseWhen function for enum type (#29454)#29510
ti-chi-bot merged 2 commits intopingcap:release-5.1from
ti-srebot:release-5.1-ae65cae8d04c

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 5, 2021

cherry-pick #29454 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/29510

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/29510:release-5.1-ae65cae8d04c

What problem does this PR solve?

Issue Number: close #29357

Problem Summary:

What is changed and how it works?

There are two problem in this issue:
Problem 1:

  1. caseWhenFunctionClass.getFunction get fieldType Enum from children, and construct scalarFunction caseWhenString.
  2. compareFunctionClass.getFunction get fieldType Int and Enum, and set EnumSetAsInt flag, but not re-construct caseWhen function.
  3. Get the final scalarFunction EQInt(1, CaseWhenString(0, Enum)) and pushdown. CaseWhenString can't get int value.

Problem 2:

[tidb]> SELECT 5 = (case when 0 <=> 1 then a else a end) from t;
ERROR 1105 (HY000): baseBuiltinFunc.vecEvalInt() should never be called, please contact the TiDB team for help
  1. BuildCastFunction build a cast CastStringAsString, and the fieldType is Enum.
  2. compareFunctionClass.getFunction get fieldType Int and Enum, and set EnumSetAsInt flag, but not re-construct Cast function.
  3. Get the final scalarFunction EQInt(1, CastStringAsString(Enum))). CastStringAsString can't get int value.
    BuildCastFunction is useless. See constant_fold.goL129. We should have the same behavior for all args.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix panic for caseWhen function with enum type

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ichn-hu
  • lzmhhh123

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 5, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 5, 2021
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.1-cherry-pick labels Nov 5, 2021
@ti-srebot
Copy link
Contributor Author

@wshwsh12 you're already a collaborator in bot's repo.

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 25, 2022
@ichn-hu
Copy link
Contributor

ichn-hu commented Jan 25, 2022

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 25, 2022
@wshwsh12
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 46046c9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 27, 2022
@ti-chi-bot ti-chi-bot merged commit 2780dfb into pingcap:release-5.1 Jan 27, 2022
@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants