Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Check if a dataset already exists #1182

Open
1 of 2 tasks
kristinagrig06 opened this issue Sep 13, 2021 · 9 comments · May be fixed by #1287
Open
1 of 2 tasks

[FEATURE] Check if a dataset already exists #1182

kristinagrig06 opened this issue Sep 13, 2021 · 9 comments · May be fixed by #1287
Labels
enhancement good first issue hacktoberfest
Projects
Hacktoberfest

Comments

@kristinagrig06
Copy link
Contributor

@kristinagrig06 kristinagrig06 commented Sep 13, 2021

🚨🚨 Feature Request

  • Related to an existing Issue
  • A new implementation (Improvement, Extension)

If your feature will improve HUB

Need a way to check if a dataset already exists.

hub.empty throws an error if a dataset exists and hub.load throws an error if the dataset does not exist.

Need a way to check if a dataset already exists without throwing an error.

Description of the possible solution

Suggested API:

hub.exists(path)   # Returns True if a dataset exists in path, else False

Difficulty: Medium-easy
@tatevikh tatevikh added this to Easy tasks in Hacktoberfest Sep 13, 2021
@tatevikh tatevikh moved this from Easy tasks to Medium tasks in Hacktoberfest Sep 13, 2021
@tatevikh tatevikh moved this from Medium tasks to Easy tasks in Hacktoberfest Sep 13, 2021
@sparkingdark
Copy link
Contributor

@sparkingdark sparkingdark commented Sep 23, 2021

@kristinagrig06 is this up for grab,give it a try.

Loading

@dhiganthrao
Copy link
Member

@dhiganthrao dhiganthrao commented Sep 23, 2021

@sparkingdark, hey there, and welcome to the Hacktoberfest issues! Do you have a proposed solution in mind?

Loading

@sparkingdark
Copy link
Contributor

@sparkingdark sparkingdark commented Sep 23, 2021

Hey as I am gone for a long time so I first need to check the codebase so that's why I pick this and after that I can come up with a solution,if that is okay let's assign me.

Loading

@dhiganthrao
Copy link
Member

@dhiganthrao dhiganthrao commented Sep 23, 2021

Sure, will assign you to this issue and you can work on a solution!

Loading

@dhiganthrao dhiganthrao mentioned this issue Sep 23, 2021
Open
2 tasks
@dhiganthrao
Copy link
Member

@dhiganthrao dhiganthrao commented Oct 8, 2021

@sparkingdark, just checking up - any questions/updates you'd like to share with us on this issue? 😄

Loading

@dhiganthrao
Copy link
Member

@dhiganthrao dhiganthrao commented Oct 20, 2021

@sparkingdark - Bumping this up in case you missed it! 😄

Loading

renegaderyu added a commit to renegaderyu/Hub that referenced this issue Oct 24, 2021
@renegaderyu
Adds an exits staticmethod to the api.dataset class. Closes activeloo 1�7
265277d 
…pai#1182.
@renegaderyu renegaderyu linked a pull request that will close this issue Oct 24, 2021
Open
7 tasks
@dhiganthrao dhiganthrao linked a pull request that will close this issue Oct 25, 2021
Adds an exits staticmethod to the api.dataset class. Closes #1182. #1287
Open
7 tasks
@ChandanChainani
Copy link

@ChandanChainani ChandanChainani commented Oct 26, 2021

@dhiganthrao Is the task finished or can i work on it if no one is working?

Loading

@sparkingdark
Copy link
Contributor

@sparkingdark sparkingdark commented Oct 26, 2021

Loading

@dhiganthrao
Copy link
Member

@dhiganthrao dhiganthrao commented Oct 26, 2021

Hey @ChandanChainani - welcome to Hub and Hacktoberfest! There's a PR open for this issue but you can work on this issue if you have a different solution in mind!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue hacktoberfest
Projects
Hacktoberfest
Easy tasks
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Adds an exits staticmethod to the api.dataset class. Closes #1182.
4 participants
@ChandanChainani @sparkingdark @dhiganthrao @kristinagrig06