Current clean up method might cause some problems

[PeterDaveHello]

e.g.

uri = 'https://123.com/?ref=1234&fb_ref=4567'
uri = uri.replace(/&?ref=[^&#$/]*/gi, '');

The result will be: https://123.com/?&fb_ which I assume is not what we expected.

Ref:

facebook-direct-links/direct.js

Line 59 in 777654b

uri = uri.replace(/&?ref=[^&#$/]*/gi, '');

[Mte90]

Uhm the issue is that facebook use that parameter as I can remember but I don't know if it is doing after the new UI.

[PeterDaveHello]

The problem will not only happen on facebook, but all parameters end with ref, e.g.

uri = 'https://123.com/?site_ref=4567'
uri = uri.replace(/&?ref=[^&#$/]*/gi, '');

The result of the uri will be: https://123.com/?site_

[PeterDaveHello]

The match pattern needs to confirm if it's matching the whole query string parameter, not just the end of it.

[Mte90]

You are right can you do a PR?
Maybe it's the case to do it for all of them.

[PeterDaveHello]

I'll take a while to see which implementation would be more suitable, but I don't think you need to wait for that, as I can not commit a date time to do so.

[Mte90]

Released a new version with the latest changes for Firefox :-)

[PeterDaveHello]

Nice, BTW, the git tag seemed to be missed: https://github.com/Mte90/facebook-direct-links/releases / https://github.com/Mte90/facebook-direct-links/tags

[Mte90]

Oh quite simple, I forgot it 😂

[PeterDaveHello]

Could consider to enable some CI flow to automatically trigger the release from git tag, with some tests and lints to ensure the quality ;)

[Mte90]

Yes I have already on other extension but this one as so ffew updates that right now is not worth it.
I mean this was the first release in an year 😅

[PeterDaveHello]

Just got a though of some ugly workaround:

- uri = uri.replace(/&?ref=[^&#$/]*/gi, '');
+ uri = uri.replace(/([&|?])ref=[^&#$/]*/gi, '$1');

The result is not pretty, will make sure there is a leading ? or &, and just keep it, instead of remove it, not looking good, but at least won't break things, what do you think?

[PeterDaveHello]

uri = 'https://123.com/?ref=4567&fb_ref=123&ref=333&jdksaldref=123213'
uri = uri.replace(/([&|?])ref=[^&#$/]*/gi,'$1')

The result will be: https://123.com/?&fb_ref=123&&jdksaldref=123213

uri = 'https://123.com/?ref=4567&fb_ref=123&ref=333&jdksaldref=123213'
uri = uri.replace(/([&|?])ref=[^&#$/]*/gi,'$1')

The result will be: https://123.com/?&fb_&jdksald

[Mte90]

uhm we need to remove the fb_ parameter to do a good job, I guess that with a bit of regex we can do it.

[PeterDaveHello]

@Mte90 we sure do, the example doesn't contain the match of fb_ref regex, just to demo that it won't faulty remove something. Some final improvement can come after those replacement, to remove duplicated &.

[Mte90]

Perfect :-)
Waiting for the PR :-D