[cmake] Move a bunch of test binaries from install component 'tools' -> 'testsuite-tools'. #40077
Conversation
|
@swift-ci test |
|
@swift-ci build toolchain |
Thanks! This definitely should help improve the CI space usage on Windows.
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
Some measurements - this reduced the build artifacts from 3.9G to 3.5G. |
|
@compnerd just a FYI, I am checking with some people to make sure my guesstimates on what we can remove here is correct. |
|
@gottesmm - sounds good; I would be more clear though - it isn't being removed, only being given additional control when building with the LLVM distribution mechanism. If you use a standalone Swift build, this will not have any impact. |
LGTM for swift-ide-test, swift-syntax-parser-test and swift-syntax-test.
…-> 'testsuite-tools'. All of these are tools that are only meant to be used when testing swift. Thus it doesn't make sense to include them in the catch all 'tools' install component that distributions use to build all the tools. I verified that all of the mac/linux presets in tree that have tools also has testsuite-tools so this should be NFC. On Windows, I needed to add testsuite-tools to build-windows.bat so should be NFC there as well.
gottesmm
force-pushed
the
pr-2ea314186d00544a71b7886ab6ef6743b4b560ab
branch
from
df5f9f5
to
06cb5c0
|
I removed swift-ide-test since I think some people depend on it. I think I am going to include it in a different category though. |
|
@swift-ci smoke test |
All of these are tools that are only meant to be used when testing swift. Thus
it doesn't make sense to include them in the catch all 'tools' install component
that distributions use to build all the tools.
I verified that all of the mac/linux presets in tree that have tools also has
testsuite-tools so this should be NFC. On Windows, I needed to add
testsuite-tools to build-windows.bat so should be NFC there as well.
The text was updated successfully, but these errors were encountered: