jplhomer
Follow
jplhomer
Follow
Pinned Loading
5,594 contributions in the last year
Less
More
Activity overview
Loading
Contribution activity
November 2021
Created 39 commits in 2 repositories
Created a pull request in Shopify/hydrogen that received 2 comments
fix: LocalizationProvider in a Suspense boundary
Description
RE: #64
@frandiox discovered we aren't wrapping <LocalizationProvider> in a Suspense boundary. That means that when the query runs unc…
+12
−9
•
2
comments
Opened 10 other pull requests in 1 repository
Shopify/hydrogen
10
merged
- chore: request more repros in bug reports
- chore: improve Stackblitz publishing flow
- feat: bump Vite deps to latest version
- fix: eliminate use of client component re-exports
- chore: tell linter to ignore auto-gen types file which is super noisy
- chore: remove more logs that I missed
- chore: add note about dev preview
- fix: minor fixes to the template
- chore: update PR template to direct docs updates here
- fix: remove cache-related console logs
Reviewed 28 pull requests in 3 repositories
Shopify/hydrogen
26 pull requests
- Add support for product reference metafields
- fix(#201): normalize POSIX separators to support windows
- chore: improve Stackblitz publishing flow
- fix: new lines in hydration response
- fix: should not use switch outside a router
- [Starter] Fix Safari Product Image Gallery
- fix: delay writing error response until headers are set
- Fix client component imports and duplicated files/contexts in browser
- feat: h2 snippets package
- feat: Lint changelogs for "Keep a changelog" semantics
- feat: Adds tophat script
-
Remove
CartProviderfrom theBuyNowButton - fix: ESLint config fixes
- feat: Pass instantiated Debug logger to cli command Env
- fix: where react props can be null, yet still technically an "object"
- fix: fix server state to use pathname
- [Template] Fix No Collections Case
- Fix warning on elements with interactionPromptThreshold
-
fix: make the URL search property available via
useLocation() - [Template] Re-export Link component
- fix: make sure all errors present a nice error to the user in dev mode
- Better cart line quantity adjustsments
- feat: use country server state in cart for the inContext directive
-
Add
clicommand for page creation -
remove
@shopify/eslint-plugindependencies - Some pull request reviews not shown.
vitejs/vite
1 pull request
Shopify/quilt
1 pull request
Created an issue in Shopify/hydrogen that received 7 comments
[BUG] Vite dev server hangs on initial page load
Describe the bug Vite's dev server seems to hang when running a fresh project. It seems to happen on the first page load, where the initial SSR res…
7
comments
Opened 6 other issues in 1 repository
Shopify/hydrogen
3
closed
3
open
- [BUG] Scroll is reset on page navigation, even in cases where it feels weird
- [BUG] New line in RSC response prevents hydration from working
- Test & prep new Vite plugin-react
- [BUG] RSC client components displaying warning in Vite dev console
- Wire up Stackblitz shortcut to use GitHub template
- Stream responses in Worker runtimes where it is supported
58
contributions
in private repositories
Nov 2 – Nov 10