Skip to content

Conversation

@PakkuDon
Copy link
Contributor

refs: #13648
Moment is in maintenance mode and is no longer recommended for use

  • There's a clear use-case for this code change
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test and yarn lint)

refs: TryGhost#13648
Moment is in maintenance mode and is no longer recommended for use
@ErisDS
Copy link
Member

ErisDS commented Oct 28, 2021

Hi @PakkuDon thanks for this PR 🙏 I've just been testing it out and although it passes the tests it doesn't actually work. Our tests relied on the fact moment would cope with any type of date and so uses new Date(). Your code uses DateTime.fromJSDate which works with this test data.

However in the real world this results in "Invalid DateTime".

I tried using fromISO, which results in the date being parsed, but the .toFormat() function works differently to moment so this results in YYYY-10-21 Oct 2021 09:02:10 instead of 2021-10-21 09:02:10.

@github-actions
Copy link
Contributor

Our bot has automatically marked this PR as stale because there has not been any activity here in some time.

If we’ve missed reviewing your PR & you’re still interested in working on it, please let us know. Otherwise this PR will be closed shortly, but can always be reopened later. Thank you for understanding 🙂

@github-actions github-actions bot added the stale [triage] Issues that were closed to to lack of traction label Feb 26, 2022
@github-actions github-actions bot closed this Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale [triage] Issues that were closed to to lack of traction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants