Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeepTogether on ListItem not implemented #380

Open
stonewoodman opened this issue Jun 18, 2020 · 2 comments
Open

KeepTogether on ListItem not implemented #380

stonewoodman opened this issue Jun 18, 2020 · 2 comments
Labels
enhancement good first issue

Comments

@stonewoodman
Copy link

@stonewoodman stonewoodman commented Jun 18, 2020

The value keeptogether on a ListItem is ignored

ListItem listItem = new ListItem("multiline text...", font);
listItem.setKeepTogether(true);

expected result
The flag has the same behavior as by Paragraph.
@andreasrosdal
Copy link

@andreasrosdal andreasrosdal commented Jun 18, 2020

Pull requests welcome.

@arnthom
Copy link

@arnthom arnthom commented Jun 18, 2020

OK, method getKeepTogether() is used in PdfDocument.add(Element) if the element is Paragraph, but not if it is ListItem, although ListItem extends Paragraph ...

public boolean add(Element element) throws DocumentException {
...
        try {
            switch(element.type()) {
...
                case Element.PARAGRAPH: {
...
                    // if a paragraph has to be kept together, we wrap it in a table object
                    if (paragraph.getKeepTogether()) {
...
                case Element.LISTITEM: {
...

@whexy whexy mentioned this issue May 21, 2021
Closed
@whexy whexy mentioned this issue May 22, 2021
Closed
2 tasks
@asturio asturio linked a pull request May 24, 2021 that will close this issue
Implement KeepTogether on ListItem #545
Closed
@asturio asturio linked a pull request May 24, 2021 that will close this issue
feat: keeptogether on a ListItem #547
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stonewoodman @asturio @arnthom @andreasrosdal