Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Add tests that run the whole action #149

Merged
merged 5 commits into from Jun 4, 2021
Merged

🧹 Add tests that run the whole action #149

merged 5 commits into from Jun 4, 2021

Conversation

@pje
Copy link
Member

@pje pje commented Jun 3, 2021

This adds some basic tests to confirm the behavior of running the whole action. I'm using Jest mocks for the Github API.

My Jest knowledge is pretty minimal. In particular the way I'm mocking the GitHub API feels janky. Feedback appreciated!

@pje pje requested a review from as a code owner Jun 3, 2021
@pje pje changed the title 🧹 Add tests that run the whole action 🧹 Add tests that run the whole action Jun 3, 2021
@pje pje requested a review from thboop Jun 3, 2021
__tests__/main.test.ts Outdated Show resolved Hide resolved
Loading
__tests__/main.test.ts Show resolved Hide resolved
Loading
thboop
thboop approved these changes Jun 4, 2021
Copy link
Collaborator

@thboop thboop left a comment

LGTM

Loading

@pje
Copy link
Member Author

@pje pje commented Jun 4, 2021

Thanks for all your thoughtful comments, @thboop!

Loading

@pje pje merged commit c9d0dfc into main Jun 4, 2021
4 checks passed
Loading
@pje pje mentioned this pull request Jun 4, 2021
@pje pje deleted the basic-functional-test branch Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants