Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Improve verification steps for defining workspace deployment labels&annotations article #19427

Open
themr0c opened this issue Mar 26, 2021 · 6 comments
Open

[doc] Improve verification steps for defining workspace deployment labels&annotations article #19427

themr0c opened this issue Mar 26, 2021 · 6 comments
Labels
area/doc good first issue kind/enhancement severity/P2 team/doc

Comments

@themr0c
Copy link
Contributor

@themr0c themr0c commented Mar 26, 2021 •
edited
Loading

https://che-host/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&workspaceDeploymentLabels=ike.target%3Dpreference-v1%2Cike.session%3Dtest

and

https://che-host/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&workspaceDeploymentAnnotations=ike.A1%3Dpreference-v1%2Cike.A%3Dtest

apiVersion: 1.0.0
metadata:
  name: quarkus-quickstarts-l263x
...

Expected: labels / annotations as presented in the examples: https://www.eclipse.org/che/docs/che-7/end-user-guide/creating-a-workspace-from-remote-devfile/#allowing-users-to-define-workspace-deployment-labels-and-annotations_che
@sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Mar 26, 2021

I just tried it on the same Che cluster, which @themr0c used and it works for me. Probably there is some confusion point.
Screenshot_20210326_165928

Loading

@themr0c
Copy link
Contributor Author

@themr0c themr0c commented Mar 29, 2021

I could reproduce using: http://workspaces.openshift.com/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&workspaceDeploymentLabels=ike.target%3Dpreference-v1%2Cike.session%3Dtest

Screenshot from 2021-03-29 08-24-11

Loading

@themr0c
Copy link
Contributor Author

@themr0c themr0c commented Mar 29, 2021

Wait ... That's where the confusion is: I should have looked at the deployment label and not at the devfile.

We should probably be more specific in the documentation: add verification steps:

"In the OpenShift console @@ do this to display the deployment labels @@"

Loading

@MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Mar 29, 2021

Related doc issue https://issues.redhat.com/browse/RHDEVDOCS-2884

Loading

@MichalMaler
Copy link
Contributor

@MichalMaler MichalMaler commented Mar 30, 2021 •
edited
Loading

Working on in in eclipse/che-docs#1937

Loading

@sleshchenko sleshchenko changed the title define workspace deployment labels and annotations doesn't work on dashboard next Improve verification steps for defining workspace deployment labels&annotations docs article Apr 2, 2021
@sleshchenko sleshchenko changed the title Improve verification steps for defining workspace deployment labels&annotations docs article [doc] Improve verification steps for defining workspace deployment labels&annotations article Apr 2, 2021
@fcomte
Copy link

@fcomte fcomte commented Aug 19, 2021

I am unable to make this functionnality on my che server.

Version
7.34.0
Browser Name
chrome
Browser Version
84.0.4147
Browser OS
Windows 10

Trying to launch this url :

https://che-host/f?url=https://github.com/maxandersen/quarkus-quickstarts/tree/che&workspaceDeploymentLabels=ike.target%3Dpreference-v1%2Cike.session%3Dtest

give this

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: "1"
  creationTimestamp: "2021-08-19T12:13:04Z"
  generation: 1
  labels:
    che.component.name: maven
    che.original_name: maven
    che.workspace_id: workspace2tcai8b5i7xth0x3

Is there any prerequisites on the eclipse che server configuration ?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/doc good first issue kind/enhancement severity/P2 team/doc
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@themr0c @sleshchenko @che-bot @MichalMaler @fcomte