Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expected failure for tflite notebook test. #7534

Merged
merged 1 commit into from Nov 3, 2021
Merged

Remove expected failure for tflite notebook test. #7534

merged 1 commit into from Nov 3, 2021

Conversation

@ScottTodd
Copy link
Collaborator

@ScottTodd ScottTodd commented Nov 3, 2021

Something in #7501 fixed this :D
@ScottTodd ScottTodd requested a review from GMNGeoffrey Nov 3, 2021
@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@ScottTodd ScottTodd enabled auto-merge (squash) Nov 3, 2021
@GMNGeoffrey
Copy link
Member

@GMNGeoffrey GMNGeoffrey commented Nov 3, 2021

Maybe run the samples build on this PR before merging?

@ScottTodd
Copy link
Collaborator Author

@ScottTodd ScottTodd commented Nov 3, 2021 •
edited

Maybe run the samples build on this PR before merging?

#yolo. I ran this particular test (under Docker) locally and trust my reading of the error logs on https://buildkite.com/iree/iree-samples/builds/138 enough

@ScottTodd ScottTodd merged commit cf9540a into google:main Nov 3, 2021
16 checks passed
@ScottTodd ScottTodd deleted the colab-xfail branch Nov 3, 2021
@not-jenni not-jenni mentioned this pull request Nov 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMNGeoffrey GMNGeoffrey

Assignees
No one assigned
Labels
cla: yes infrastructure 🛠️ integrations/colab
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ScottTodd @GMNGeoffrey