Added flatpak build manifests with split dependencies#1768
Open
kdcis wants to merge 1 commit intoBitmessage:v0.6from
Open
Added flatpak build manifests with split dependencies#1768kdcis wants to merge 1 commit intoBitmessage:v0.6from
kdcis wants to merge 1 commit intoBitmessage:v0.6from
Conversation
PeterSurda
requested changes
Jun 3, 2021
PeterSurda
requested changes
Jun 23, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
Please update documentation
g1itch
reviewed
Jun 23, 2021
g1itch
reviewed
Jun 23, 2021
g1itch
reviewed
Jun 23, 2021
Collaborator
|
Also, I don't get a point of documenting the maintenance tasks in such way. Why don't you just make a script There supposed to be a builder on |
Member
|
@g1itch I'm working on the buildbot integration. |
PeterSurda
requested changes
Aug 4, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
Clean up, rebase and then I'll look at it again.
kdcis
force-pushed
the
v0.6-flatpak
branch
4 times, most recently
from
07316eb to
a9d9356
Compare
PeterSurda
requested changes
Aug 5, 2021
| # PyBitmessage Linux flatpak instructions | ||
|
|
||
| ## Requirements | ||
| First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed. |
Contributor
Author
There was a problem hiding this comment.
As it is a readme file, I don't think there would be any pylint line too long warning will happen.
Please confirm if still I need to break it.
Member
There was a problem hiding this comment.
I don't have a strong opinion so we can probably just leave it as it is.
kdcis
force-pushed
the
v0.6-flatpak
branch
7 times, most recently
from
48ee56a to
eaadcf0
Compare
PeterSurda
reviewed
Aug 27, 2021
Member
PeterSurda
left a comment
PeterSurda
left a comment
There was a problem hiding this comment.
I think we can merge it, the buildbot integration can be deployed later.
| # PyBitmessage Linux flatpak instructions | ||
|
|
||
| ## Requirements | ||
| First make sure you have `flatpak` and `flatpak-builder` installed along with these dependencies (Ubuntu 20.4) `git xz-utils elfutils librsvg2-common` needs to be installed. |
Member
There was a problem hiding this comment.
I don't have a strong opinion so we can probably just leave it as it is.
kdcis
force-pushed
the
v0.6-flatpak
branch
3 times, most recently
from
26216cb to
1753c97
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
3 times, most recently
from
9b95345 to
bfa611b
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
7 times, most recently
from
57b05f9 to
e607cda
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
5 times, most recently
from
0036dcd to
2ce0698
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
4 times, most recently
from
d0f73d0 to
f4edee1
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
3 times, most recently
from
73d8238 to
d42f807
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
2 times, most recently
from
c1d6e7d to
0a718dc
Compare
kdcis
force-pushed
the
v0.6-flatpak
branch
5 times, most recently
from
65ef4bb to
475dca3
Compare
Removed extra lines from build sequence Added Dockerfile for Flatpak repo-server & Build instructions under docs/ dir Modified Dockerfile & Flatpak build doc updated docs fixed code quality issues fixed code quality, added doc string fixed branch & added build commands run setuptools fixed code quality refactor pip install updated flatpak build doc & added link to index.rst Removed extra lines from build sequence Added Dockerfile for Flatpak repo-server & Build instructions under docs/ dir Modified Dockerfile & Flatpak build doc updated docs fixed code quality issues fixed code quality, added doc string fixed branch & added build commands run setuptools fixed code quality refactor pip install updated flatpak build doc & added link to index.rst fixed docs rebased removed unnecessary files removed .gitmodules: should be part of build process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Flatpak build manifests under
packages/flatpak/directoryAdded Flatpak build instructions under
docs/directory