Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize dartdoc step in cicd #954

Closed
spydon opened this issue Sep 15, 2021 · 2 comments
Closed

Parallelize dartdoc step in cicd #954

spydon opened this issue Sep 15, 2021 · 2 comments
Labels
enhancement hacktoberfest

Comments

@spydon
Copy link
Member

@spydon spydon commented Sep 15, 2021

What could be improved

It takes 17 minutes to run the flame-dartdoc-action since it is running it sequentially on all projects in the monorepo. It should be parallelized and it should bring down the time to ~3 minutes.

Why should this be improved

Because waiting is bad for your sanity.

Any risks?

You might not have time to make new coffee before each merge.

More information
@mugbug
Copy link
Contributor

@mugbug mugbug commented Oct 17, 2021

Hey, can I give this one a try?

@mugbug mugbug mentioned this issue Oct 17, 2021
Merged
mugbug added a commit to mugbug/flame that referenced this issue Oct 17, 2021
@mugbug
flame-engine#954 - enable parallel dartdoc step in cicd
6c00c45
@mugbug mugbug mentioned this issue Oct 17, 2021
Merged
11 tasks
mugbug added a commit to mugbug/flame that referenced this issue Oct 18, 2021
@mugbug
flame-engine#954 - use flame-engine/flame-dartdoc-action@v2 action
e1cbf95
@mugbug mugbug mentioned this issue Oct 18, 2021
Open
erickzanardo added a commit that referenced this issue Oct 20, 2021
@mugbug @spydon @erickzanardo
Enable parallel dartdoc step in cicd (#1029)
564792c 
* #954 - enable parallel dartdoc step in cicd

* #954 - use flame-engine/flame-dartdoc-action@v2 action

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Erick <erickzanardoo@gmail.com>
@spydon
Copy link
Member Author

@spydon spydon commented Oct 22, 2021

This is working and cut down the run time by a lot, great job @mugbug!

@spydon spydon closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@spydon @luanpotter @mugbug