encryption

Hi. First of all, kudos to you for the VFS cache - it's really brilliant. I have one request though.

For a little background, as of now I'm using the following settings:

--vfs-cache-mode full \
  --vfs-cache-max-size 500G \
  --vfs-cache-max-age 5000h \
  --vfs-cache-poll-interval 5m \
  --vfs-read-ahead 2G \
  --bwlimit-file 32M \
  --vfs-read-chunk-size=64M \
  --vfs-read-chunk-s

OS/Environment

None yet, but I'm working on OS X v10.11.6 'El Capitan' client-side. (See 'The way of deployment (cloud or local)' below for details on considered server infrastructure.)

Ansible version

None yet, as I haven't yet gotten that far into setting up Algo.

Version of components from requirements.txt

Not applicable (see above.)

Summary of the pro

I'm using a /etc/cron.daily/ file that does:

#!/bin/sh

BITS=4096
GENERATOR=-2

openssl dhparam -out /etc/pki/tls/misc/dhparam.pem.new \
		$GENERATOR $BITS > /dev/null \
	&& mv -f /etc/pki/tls/misc/dhparam.pem.new /etc/pki/tls/misc/dhparam \
	&& apachectl restart

to generate daily dhparam files which I then use in ssl.conf as:

SSLOpenSSLConfCmd DHParameters /e

Is your feature request related to a problem? Please describe.
When working with a big piece of text, I sometimes scroll down and copy some text into another tab. When switching back to the first tab, both the input and the output pane is back on top. So I don't know where I was working just now.

Describe the solution you'd like
After tab switching, scroll position should be remembere

Since some time, the macOS CI run via github actions usually gets killed before it is finished.

We should try to make it faster so it doesn't get killed by github for running too long.

Likely, it is not the tests taking too long, but some preparational steps.

When a contact is already added, open the contact profile or the existing conversation

The error check is done here: https://github.com/berty/berty/blob/097eb0229f22e2abce3addd750c8dce98e92845f/js/packages/components/modals/InvalidScan.tsx#L126

We shouldn't show the invalid scan modal but navigate instead

What went wrong?

I'm getting deprecation warnings with openSSL encryption.

[2019/09/05 08:38:52][info] Using Encryptor::OpenSSL to encrypt the archive.
[2019/09/05 08:40:22][warn] Pipeline STDERR Messages:
[2019/09/05 08:40:22][warn] (Note: may be interleaved if multiple commands returned error messages)
[2019/09/05 08:40:22][warn]
[2019/09/05 08:40:22][warn] *** WARNING : depre

Most of the time we display FAQ links as raw URLs, like this:

But in some places (at least in Settings → Subscription → Gift cards) we just make it a link with a text.

Problem:

A common pattern is:

GUARD(s2n_stuffer_skip_write(stuffer, bytes_to_write));
uint8_t* ptr = suffer->blob.data + stuffer->write_cursor - bytes_to_write;

which could be simplified.

Solution:

*ptr could be an *out parameter to s2n_stuffer_skip_write

• Does this change what S2N sends over the wire? No.
• Does this change any public APIs? No.

For classes declared with struct, forward declarations should also use struct. Currently, only struct Message violates this in a few header files (2 or so?).