Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRefactoring ES6 #533
Refactoring ES6 #533
Conversation
utdrmac
commented
Jul 14, 2018
|
This is awesome. Glad to see there's still life and interest in this project. Is there a README or documentation on the additional functionality? |
|
@utdrmac No not yet. The options are (with defaults): const defaults = {
sourceUrl: null,
ratio: '4:3',
highlightStyle: 'default',
highlightLines: false,
highlightSpans: false,
highlightInlineCode: false,
highlightLanguage: '',
slideNumberFormat: '%current% / %total%',
cloneTarget: '_blank',
excludedClasses: [],
countIncrementalSlides: true,
macros: {},
transition: false,
transitionSpeed: false,
slideNumber: false,
progressBar: false,
controls: false,
controlsTutorial: false,
controlsLayout: 'bottom-right',
controlsBackArrows: 'faded',
folio: false,
allowControl: true,
navigation: {},
translations: {}
};For the ported settings (controls, transition, progress bar), see https://github.com/hakimel/reveal.js/#configuration. |
utdrmac
commented
Jul 15, 2018
|
Did you upgrade to the most recent version of marked or did you possibly switch to using CommonMark? |
|
Edit: Sorry I over read the that you asked for the update of marked. No I don't. |
|
I updated to marked 0.4.0, options for marked can be set using |
utdrmac
commented
Aug 7, 2018
|
I'm not a github/git guru. What's the best way to test this PR? |
|
I made an archive for you: https://github.com/GM-Alex/remark/releases/download/es6-rework/remark-es6.zip I also add an easy way to use columns just use |
jingsam
commented
Aug 28, 2018
|
@GM-Alex That's great works. Since the author has dropped maintenance of remarkjs, could you contact the author to transfer this project to you? |
jingsam
commented
Aug 28, 2018
|
I made a simple test, find that when
|
GM-Alex commentedJul 14, 2018
This is a refactored version using ES6, adds i18n support, switches from less to sass, uses webpack, ports the slide transitions, the progress bar and the controls from reveal.js and adds some additional functionality. Maybe this could be used some day.