[SPARK-37717][SQL] Improve logging in BroadcastExchangeExec#34990
Closed
ekoifman wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-37717][SQL] Improve logging in BroadcastExchangeExec#34990ekoifman wants to merge 1 commit intoapache:masterfrom
ekoifman wants to merge 1 commit intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Contributor
|
@ekoifman please update the pr title |
ekoifman
changed the title
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The logging and errors from inside
override lazy val relationFuture: Future[broadcast.Broadcast[Any]] = { SQLExecution.withThreadLocalCaptured[broadcast.Broadcast[Any]]( session, BroadcastExchangeExec.executionContext) { try { ..... }are hard to relate to the right join in a plan with lost of Broadcast joins.
Spark UI displays
BroadcastExchangeExec.runIdbut it's not in the logs.
Why are the changes needed?
Does this PR introduce any user-facing change?
Logs will now look like
2021-11-13 21:14:59,028 INFO [broadcast-exchange-6-e20800a6-5204-40c5-82d8-40662affc244] [tenant:] [app: ] [appID:application_1627787411812_5950609] [executor:driver] [cid: ] [prid: ] TaskMemoryManager: org.apache.spark.memory.TaskMemoryManager.acquireExecutionMemory(TaskMemoryManager.java:238) - null (TID 0) acquired 16.0 KiB for org.apache.spark.unsafe.map.BytesToBytesMap@33bfacf0instead of
2021-11-13 21:14:59,028 INFO [broadcast-exchange-6] [tenant:] [app: ] [appID:application_1627787411812_5950609] [executor:driver] [cid: ] [prid: ] TaskMemoryManager: org.apache.spark.memory.TaskMemoryManager.acquireExecutionMemory(TaskMemoryManager.java:238) - null (TID 0) acquired 16.0 KiB for org.apache.spark.unsafe.map.BytesToBytesMap@33bfacf0How was this patch tested?
Existing tests