Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PID column to processes table #159

Open
llchan opened this issue Mar 31, 2020 · 7 comments
Open

Add PID column to processes table #159

llchan opened this issue Mar 31, 2020 · 7 comments
Labels
good first issue help wanted

Comments

@llchan
Copy link

@llchan llchan commented Mar 31, 2020

It would be useful to be able to toggle/flag into a process-level mode to group by pid and display more process-level information like the full command line.

  • For the "Utilization by process name" window, we could group by pid rather than process name so that it's easier to find specific heavy network resource consumers.
  • For the "Utilization by connection" window, including the pid + cmdline would be helpful in distinguishing processes without extra work to map the port to a pid.

I can give this a shot. I've been looking for a small PR to get some exposure to Rust anyways.

@imsnif
Copy link
Owner

@imsnif imsnif commented Apr 1, 2020

Hey @llchan, thanks for the suggestion. I must admit I'm a little weary of adding stuff like this. I feel these sorts of features are something that could be implemented "on top" of bandwhich. Either requiring it as a library or using raw_mode.

If you're looking for something to work on, I'd be happy to suggest some issues that need work, or maybe come up with something together?

@llchan
Copy link
Author

@llchan llchan commented Apr 1, 2020

Totally understand. Feel free to stick a help-wanted label on this and leave it for the community to add. I was mostly filing an issue for visibility before tinkering.

I'll look into the raw mode or library mode, but given that you've already set up the TUI bits I'd prefer to add it in there rather than starting a new project. Just thinking out loud here, but maybe if you want to set different maintenance expectations for the bandwhich core library and the bandwhich TUI/CLI app, you could consider splitting it into two packages, with a more community-supported workflow for the app layer?

@kaushalyap
Copy link

@kaushalyap kaushalyap commented Apr 2, 2020

@imsnif It would be good to see process id (PID) in the table.

And for some processes it shows <UNKNOWN> for the process name

@imsnif
Copy link
Owner

@imsnif imsnif commented Apr 2, 2020

Alright - I'd be open to adding the PID to the process table as a separate column.
Note that we'd have to take care to have it react to size changes like the rest of the table does. It would probably be the first thing to go before the "Connections" column.

I'm putting a "Help Wanted" on this, but if one of you wants to implement it, let me know and I'll remove it.

@imsnif imsnif changed the title Detailed Process Information Add PID column to processes table Apr 2, 2020
@imsnif imsnif added good first issue help wanted and removed discussion labels Apr 2, 2020
@olehs0
Copy link
Contributor

@olehs0 olehs0 commented Apr 5, 2020

@imsnif @llchan I'm going to investigate this issue. It could be a good job.

@hulleyrob
Copy link

@hulleyrob hulleyrob commented Sep 21, 2020

And for some processes it shows <UNKNOWN> for the process name

Is this likely to be fixed as part of this issue or would you like a separate issue for this?
I wasn't clear if this was something to do with "DNS queries hidden" or not.

@imsnif
Copy link
Owner

@imsnif imsnif commented Sep 22, 2020

Hey @hulleyrob - I think in cases where we see <UNKNOWN> we won't see a PID either. <UNKNOWN> means bandwhich could not figure out which process certain traffic belongs to for various reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted
Projects
None yet
Development

No branches or pull requests

5 participants