Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing all tabs on SQL Lab leaves the screen blank #17630

Open
2 tasks done
villebro opened this issue Dec 2, 2021 · 2 comments · May be fixed by #17700
Open
2 tasks done

Closing all tabs on SQL Lab leaves the screen blank #17630

villebro opened this issue Dec 2, 2021 · 2 comments · May be fixed by #17700
Labels
bug:cosmetic #bug good first issue P1 preset-io

Comments

@villebro
Copy link
Member

@villebro villebro commented Dec 2, 2021

When closing all tabs on SQL Lab, the whole screen goes blank due to there not being a single open tab left.

How to reproduce the bug

  1. Go to SQL Lab
  2. Close all tabs
  3. Notice how the whole screen goes blank

Expected results

A new empty tab should be opened automatically. The same can now be achieved by clicking on SQL Lab in the menu, which correctly opens an empty tab.

Actual results

The screen goes blank

Video

close-sqllab-tab.mp4

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.
@villebro villebro added the #bug label Dec 2, 2021
@junlincc junlincc added the P1 label Dec 2, 2021
@Yahyakiani
Copy link
Contributor

@Yahyakiani Yahyakiani commented Dec 5, 2021 •
edited

@villebro @junlincc Could I have this issue ? Furthermore, what is the expected solution for this problem ? Automatically open an empty SQL tab if tabs count falls to zero upon closing ?

@nytai
Copy link
Member

@nytai nytai commented Dec 7, 2021

@Yahyakiani Doesn't seem like anyone has taken it, go for it! Yes either recreating a new empty tab or just raising an error that the last tab cannot be closed should be enough

@Yahyakiani Yahyakiani linked a pull request that will close this issue Dec 9, 2021
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:cosmetic #bug good first issue P1 preset-io
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix(Sql Lab tabs): Empty SQL lab tabs
4 participants
@nytai @villebro @Yahyakiani @junlincc