Reduce compiler warnings for C++ #6189
Comments
|
Hello, i would like to work on this issue! |
|
@sgavil Great! I'm going to assign this issue to you. Keep in mind that you don't have to eliminate all warnings in a single pull request. It will probably take several pull requests to address all warnings. |
|
See instructions for building XGBoost here: https://xgboost.readthedocs.io/en/latest/build.html#building-on-linux-distributions. Modify the CMake flags as follows: in order to show all compiler warnings. |
|
Great! Thank you |
|
I can also contribute to this, I believe there are enough warnings for 2 different PRs |
|
Mind if I jump into that too? GPU-related code has way too many warnings, would be nice to clean up some. |
|
I've noticed that most warnings (I'd say half of those) come from dmlc, so maybe some PRs would be welcome there. |
|
@igormp Yes, the compiler warning has been an issue for a while in dmlc. Would you like to take a shot? |
|
Sure! It'll try to go through it during this week. |
|
Hi, Can I try to help you in this issue? |
|
@BurakBarlas Yes! Feel free to submit a pull request. Let me know if you need help. |
|
Hello i want to work on this... |
|
@pranav-verma001 Thanks for volunteering, you can start with #6189 (comment) . Feel free to ping me if you need any assistance. ;-) |
|
@pranav-verma001 I'm not familiar with vscode IDE (I thought that's an editor instead of IDE?). As for which compiler should you use, both gcc and clang are fine. Could you please try running the following steps in a terminal inside the xgboost directory: mkdir build
cd build
cmake .. -DENABLE_ALL_WARNINGS=ON
make -j$(nproc) |
|
Okay then tell me which IDE shall I use?
When i run make -j$(nproc) I get the following error:
'make' is not recognized as an internal or external command,
operable program or batch file.
…On Fri, Jan 29, 2021 at 5:10 AM Jiaming Yuan ***@***.***> wrote:
@pranav-verma001 <https://github.com/pranav-verma001> I'm not familiar
with vscode IDE (I thought that's an editor instead of IDE?).
As for which compiler should you use, both gcc and clang are fine. Could
you please try running the following steps inside the xgboost directory:
mkdir buildcd build
cmake .. -DENABLE_ALL_WARNINGS=ON
make -j$(nproc)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6189 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQRGBDDBBDBNWLDNOM32PPTS4KXS5ANCNFSM4R7WII5Q>
.
|
|
Codeblocks is fine??
On Fri, Jan 29, 2021 at 5:28 AM Pranav Verma <pranav.verma10@gmail.com>
wrote:
… Okay then tell me which IDE shall I use?
When i run make -j$(nproc) I get the following error:
'make' is not recognized as an internal or external command,
operable program or batch file.
On Fri, Jan 29, 2021 at 5:10 AM Jiaming Yuan ***@***.***>
wrote:
> @pranav-verma001 <https://github.com/pranav-verma001> I'm not familiar
> with vscode IDE (I thought that's an editor instead of IDE?).
>
> As for which compiler should you use, both gcc and clang are fine. Could
> you please try running the following steps inside the xgboost directory:
>
> mkdir buildcd build
> cmake .. -DENABLE_ALL_WARNINGS=ON
> make -j$(nproc)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#6189 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AQRGBDDBBDBNWLDNOM32PPTS4KXS5ANCNFSM4R7WII5Q>
> .
>
|
|
@pranav-verma001 It seems like you are using Windows? |
|
yes windows 10
…On Fri, Jan 29, 2021 at 5:29 AM Jiaming Yuan ***@***.***> wrote:
@pranav-verma001 <https://github.com/pranav-verma001> It seems like you
are using Windows?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6189 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQRGBDFXTJBCRXLAWY6FE63S4KZZ7ANCNFSM4R7WII5Q>
.
|
|
Got it. Assuming you have git installed in full, and you have visual studio IDE, you should have an option mkdir build
cd build
cmake .. -DCMAKE_CONFIGURATION_TYPE=Debug -A x64
cmake --build ./ --config Debug@RAMitchell might be able to provide better suggestion. I only use Windows to debug compiler specific error ... |
|
@trivialfis can I pitch in as well? |
|
Sure! Let me know if you need any help. |
Currently, the C++ compiler generates lots of warnings: https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/master/516/pipeline/61. It would be great to reduce the number of warnings.
Note to new contributors: Post a comment here if you'd like to work on this issue. Feel free to ping me for help.
The text was updated successfully, but these errors were encountered: