Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PYTORCH]: log error #69444

Open
zgplvyou opened this issue Dec 6, 2021 · 4 comments · May be fixed by #69589
Open

[PYTORCH]: log error #69444

zgplvyou opened this issue Dec 6, 2021 · 4 comments · May be fixed by #69589
Labels
better-engineering good first issue triaged

Comments

@zgplvyou
Copy link

@zgplvyou zgplvyou commented Dec 6, 2021

there may be a log error in pytorch/aten/src/THC/THCGenerateByteTypes.h, in line2, #error "You must define THC_GENERIC_FILE before including THGenerateByteTypes.h", the "THGenerateByteTypes.h" should be "THCGenerateByteTypes.h".
bty, this file is a general file to generate files of different scalar_t, so i think, the name is better to be THGenerateTypes.h.
@malfet
Copy link
Contributor

@malfet malfet commented Dec 7, 2021 •
edited

Thank you for your suggestion. Please do not hesitate to propose the PR that addresses typo in error message

@Doswind
Copy link

@Doswind Doswind commented Dec 8, 2021

@malfet Can I do this work, I'm a new to contribute and would like to work on this.

@Doswind Doswind linked a pull request that will close this issue Dec 8, 2021
Open
@rrlcs
Copy link

@rrlcs rrlcs commented Dec 23, 2021

Hi, is this issue still open? I'm new and wanted to contribute.

@pree-T
Copy link

@pree-T pree-T commented Dec 29, 2021

Hi ! I want to work on it. Can anyone guide me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better-engineering good first issue triaged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix the error: #error "You must define THC_GENERIC_FILE before includ…
5 participants
@malfet @rrlcs @zgplvyou @pree-T @Doswind