Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to configure the Min / Max Block Size Limits #323

Open
nottherealbatman opened this issue Mar 26, 2018 · 9 comments
Open

Option to configure the Min / Max Block Size Limits #323

nottherealbatman opened this issue Mar 26, 2018 · 9 comments

Comments

@nottherealbatman
Copy link

@nottherealbatman nottherealbatman commented Mar 26, 2018

A parametrized option to set the blocksize would be useful to experiment with. As quorum is used in a private setting I think this option should be available

@lumian2015
Copy link

@lumian2015 lumian2015 commented May 24, 2018

You could change the "gasLimit" field in genesis.json file. The block size depends on the gasLimit field

Loading

@mushketyk
Copy link

@mushketyk mushketyk commented Nov 4, 2018

@jpmsam Is this task still relevant? If yes, I would like to give it a try.

Loading

@jwasinger
Copy link
Contributor

@jwasinger jwasinger commented Mar 30, 2019

You could change the "gasLimit" field in genesis.json file. The block size depends on the gasLimit field

Block size is not determined by the gasLimit.

Loading

@fixanoid
Copy link
Contributor

@fixanoid fixanoid commented Apr 1, 2019

@mushketyk, this is still an open and a desired issue. If you would like to take a crack at it, please feel free to do so. We think this would be best to add through genesis config as well not dissimilar to the merge done here: #636

Loading

@fixanoid fixanoid changed the title Option to set the blocksize Option to configure the Min / Max Block Size Apr 5, 2019
@fixanoid fixanoid changed the title Option to configure the Min / Max Block Size Option to configure the Min / Max Block Size Limits Apr 5, 2019
@Open-Rawi
Copy link

@Open-Rawi Open-Rawi commented Jun 23, 2019

@fixanoid i would like to work on this if not already completed.

Loading

@fixanoid
Copy link
Contributor

@fixanoid fixanoid commented Jul 1, 2019

@Open-Rawi all of the tickets in open state are ready to be worked on by the community, please feel free to help us out.

Loading

@ashish10677
Copy link

@ashish10677 ashish10677 commented Oct 15, 2019

As it is a good first issue, I, (being a newbie to opensource) would love to try it out. Can someone help me get started?
Thank you

Loading

@fixanoid
Copy link
Contributor

@fixanoid fixanoid commented Oct 15, 2019

@ashish10677 as mentioned in my comment, it should be similar to modifications done in #636 and #786. Excpet this time, we want the options for overwriting block size.

Loading

@sakshamk6999
Copy link

@sakshamk6999 sakshamk6999 commented Jun 18, 2020

Hi, is this issue still open ?
if so, I'd like to contribute

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants