Fix terminology #1104
Merged
Fix terminology #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-nenashev
reviewed
May 1, 2021
Let's agree on the new term before merging. I hope we can finalize it at the governance meeting on wednesday
slide
approved these changes
May 14, 2021
MarkEWaite
approved these changes
May 17, 2021
|
As far as I can tell from the job definition on ci.jenkins.io, the checks associated with this pull request will never run because the organization folder is defined to not evaluate pull requests from branches on the origin repository. I think we should merge this terminology improvement without requiring the checks pass |
oleg-nenashev
approved these changes
May 17, 2021
|
I agree, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes terminology, including the wrong changes applied in #1101.
"Controller" is not the correct term for the node built-in to Jenkins, we do not yet have a new term.
"Connecting" vs. "Attaching" is a personal preference, unless there's some special significance to the latter I recommend the former -- I've never seen "attaching" used in this context (and given Docker uses attach for e.g.
docker start -a, seems potentially misleading)Origin branch, please delete on merge.
The text was updated successfully, but these errors were encountered: