Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue that apns token is not sent during app fresh install #9152

Merged
merged 7 commits into from Jan 6, 2022
Merged

Fix an issue that apns token is not sent during app fresh install #9152

merged 7 commits into from Jan 6, 2022

Conversation

@chliangGoogle
Copy link
Contributor

@chliangGoogle chliangGoogle commented Dec 31, 2021 •
edited

This fixes #8738.

The current implementation assumes APNS token is returned from apple system always after a new FCM token is fetched and stored during app install.
Seems like APNS token can be returned faster than that and currently the client only sends out request updating APNS token with FCM token when a cached FCM token exists.
Now update the logic to if no cached token exists and a new APNS token is set, always send a request to backend to update the FCM token with the apns token.

  • Added a SwiftUI test app that uses the latest SwiftUI lifecycle
  • Removed a redundant apns token key
@google-oss-bot
Copy link

@google-oss-bot google-oss-bot commented Dec 31, 2021 •
edited

Size Report 1

Affected Products

  • FirebaseMessaging

    TypeBase (5822a5a)Merge (ee2ce69)Diff
    CocoaPods?728 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qh6cLsb3nu.html

@google-oss-bot
Copy link

@google-oss-bot google-oss-bot commented Dec 31, 2021 •
edited

Coverage Report 1

Affected Products

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from ? (5822a5a) to 63.54% (ee2ce69) by ?.

    29 individual files with coverage change

    FilenameBase (5822a5a)Merge (ee2ce69)Diff
    FIRMessaging.m?55.48%?
    FIRMessagingAnalytics.m?80.71%?
    FIRMessagingAPNSInfo.m?86.96%?
    FIRMessagingAuthKeychain.m?85.90%?
    FIRMessagingAuthService.m?92.03%?
    FIRMessagingBackupExcludedPlist.m?85.07%?
    FIRMessagingCheckinPreferences.m?97.03%?
    FIRMessagingCheckinService.m?89.19%?
    FIRMessagingCheckinStore.m?80.92%?
    FIRMessagingContextManagerService.m?66.48%?
    FIRMessagingExtensionHelper.m?78.57%?
    FIRMessagingKeychain.m?93.39%?
    FIRMessagingLogger.m?100.00%?
    FIRMessagingPendingTopicsList.m?89.02%?
    FIRMessagingPersistentSyncMessage.m?38.10%?
    FIRMessagingPubSub.m?52.14%?
    FIRMessagingRemoteNotificationsProxy.m?75.84%?
    FIRMessagingRmqManager.m?57.00%?
    FIRMessagingSyncMessageManager.m?68.89%?
    FIRMessagingTokenDeleteOperation.m?0.00%?
    FIRMessagingTokenFetchOperation.m?75.74%?
    FIRMessagingTokenInfo.m?78.86%?
    FIRMessagingTokenManager.m?37.18%?
    FIRMessagingTokenOperation.m?96.43%?
    FIRMessagingTokenStore.m?66.00%?
    FIRMessagingTopicOperation.m?0.00%?
    FIRMessagingUtilities.m?57.20%?
    NSDictionary+FIRMessaging.m?21.21%?
    NSError+FIRMessaging.m?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/46s4Ovw6d7.html

ryanwilson
ryanwilson reviewed Jan 6, 2022
View changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Mostly LGTM just a couple small things, thanks!

FirebaseMessaging/Apps/SwiftUISample/SwiftUISample.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
FirebaseMessaging/Apps/SwiftUISample/SwiftUISample/SwiftUISampleApp.swift Outdated Show resolved Hide resolved
FirebaseMessaging/Apps/SwiftUISample/SwiftUISample/SwiftUISampleApp.swift Show resolved Hide resolved
FirebaseMessaging/Apps/SwiftUISample/SwiftUISample/ContentView.swift Show resolved Hide resolved
FirebaseMessaging/Sources/Token/FIRMessagingTokenManager.m Outdated Show resolved Hide resolved
FirebaseMessaging/Sources/Token/FIRMessagingTokenManager.m Outdated Show resolved Hide resolved
FirebaseMessaging/Sources/Token/FIRMessagingTokenManager.m Outdated Show resolved Hide resolved
ryanwilson
ryanwilson approved these changes Jan 6, 2022
View changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Thanks!

@chliangGoogle chliangGoogle merged commit 8f5e7f0 into master Jan 6, 2022
33 checks passed
@chliangGoogle chliangGoogle deleted the chliang-fm-swizzling branch Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777

@ryanwilson ryanwilson

@leojaygoogle leojaygoogle

Assignees
No one assigned
Labels
api: messaging
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Firebase Messaging: Fails to receive a notifications in iOS - SwiftUI
4 participants
@chliangGoogle @google-oss-bot @paulb777 @ryanwilson