Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pivot 2] fonts are not suited to numbers (Inter) #17633

Open
squalou opened this issue Dec 2, 2021 · 2 comments
Open

[Pivot 2] fonts are not suited to numbers (Inter) #17633

squalou opened this issue Dec 2, 2021 · 2 comments

Comments

@squalou
Copy link

@squalou squalou commented Dec 2, 2021

Screenshot

I've added a red vertical ruler so that you see the issue

image

Description

As already explained in numerous issues, the use of 'Inter' font is problematic, it does not allow to align dates for instance,
and does not play nice with numbers either.

In my superset, I've changed superset-frontend/src/assets/stylesheets/less/variables.less to remove 'Inter'.
As a result it uses Helvetica, which is fine.

Except ! Go wonder why and how, Pivot Table V2 still uses 'Inter.'

At least I'd like a workaround to explain me how to build a superset docker image without Inter even for this viz.

Design input

I'm not asking for marvelous fantasies, just having aligned data in table colums, for dates and numbers.

@suddjian
Copy link
Member

@suddjian suddjian commented Dec 3, 2021

Iter is quite full-featured and allows for tabular numbers. We probably can/should figure out how to activate that rather than using a different font.

@squalou
Copy link
Author

@squalou squalou commented Dec 3, 2021

@suddjian that would be awesome and please consider checking other visualizations.

apparently pivot2 and others do not share the same css magic. Tabular numbers with Inter everywhere in tables would be fantastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants