Conversation
tailhook
force-pushed
the
fix_narratable
branch
2 times, most recently
from
9e36280 to
fb9bab6
Compare
Contributor
Author
|
Had to make the |
Fixes zkat#106 While fixing the bug I've also extended the handler to print not just where label starts but also where label ends. Also implements zkat#97, but for narratabble handler only. This adds dependency on `unicode-width`, but it was already in the dependency chain (`textwidth` depends on it). Although, previously it was only for `"fancy"` feature, now it always required since narratable handler is supported without `"fancy"`.
tailhook
force-pushed
the
fix_narratable
branch
from
fb9bab6 to
e8a3f9d
Compare
zkat
approved these changes
Jan 17, 2022
Owner
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
oh hey this is great! Thank you!
I think adding unicode-width as non-optional is ok--it's pretty small and non-invasive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
While fixing the bug I've also extended the handler to print not just
where label starts but also where label ends.
Also implements #97, but for narratabble handler only.
This adds dependency on
unicode-width, but it was already in thedependency chain (
textwidthdepends on it).