Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] legacy: refactoring of the old Logger (part 2 of 2) #1625

Merged
merged 13 commits into from Jan 21, 2022
Merged

[breaking] legacy: refactoring of the old Logger (part 2 of 2) #1625

merged 13 commits into from Jan 21, 2022

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Jan 14, 2022 •
edited

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

  • Removes legacy i18n.Logger
  • Other minor improvements to the source code

What is the current behavior?
No changes in behaviour

What is the new behavior?
No changes in behaviour

Does this PR introduce a breaking change, and is
titled accordingly?
The legacy i18n.Logger is no longer available in the builder, the Stdout and Stderr streams should be used instead.
cmaglie added 6 commits Jan 12, 2022
@cmaglie
legacy: refactored ErrorfWithLogger function
852c91a 
Now is no longer needed, this function was basically made for
arduino-builder to allow transfering the error to the IDE, BTW the
correct fix must be made inside arduino-builder (to actually let him
push the error in the logger).
@cmaglie
Renamed legacy ctx fields ExecStdout/ExecStderr to Stdout/Stderr
a7b69f2
@cmaglie
Removed empty Lint() function
5ed306f
@cmaglie
Removed dependency on i18n.Logger
01cff69
@cmaglie
Removed no more used i18n.Logger \o/ \o/
a943802
@cmaglie
Simplified i18n.Init function
43b8177
@cmaglie cmaglie linked an issue that may be closed by this pull request Jan 14, 2022
Remove/refactor legacy i18n.Logger #1623
Closed
@cmaglie cmaglie self-assigned this Jan 14, 2022
@cmaglie cmaglie marked this pull request as ready for review Jan 21, 2022
@cmaglie cmaglie requested a review from Jan 21, 2022
per1234
per1234 requested changes Jan 21, 2022
View changes
i18n/i18n.go Show resolved Hide resolved
legacy/builder/print_used_and_not_used_libraries.go Show resolved Hide resolved
legacy/builder/print_used_and_not_used_libraries.go Show resolved Hide resolved
per1234
per1234 requested changes Jan 21, 2022
View changes
docs/UPGRADING.md Outdated Show resolved Hide resolved
per1234
per1234 approved these changes Jan 21, 2022
View changes
Copy link
Contributor

@per1234 per1234 left a comment

Thanks for this important advancement Cristian!

@cmaglie cmaglie merged commit 530e671 into arduino:master Jan 21, 2022
111 of 112 checks passed
@cmaglie cmaglie deleted the some_legacy_refactoring branch Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza

@per1234 per1234

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove/refactor legacy i18n.Logger
3 participants
@cmaglie @silvanocerza @per1234