feat: load gqlgen plugins during parse schema#199
Merged
a8m merged 8 commits intoent:masterfrom Jan 7, 2022
Merged
Conversation
masseelch
requested changes
Jan 5, 2022
Collaborator
masseelch
left a comment
There was a problem hiding this comment.
Can you add tests for this?
Collaborator
Author
|
What kind of test? 😁 trying to enable federation?! |
Co-authored-by: MasseElch <12862103+masseelch@users.noreply.github.com>
Collaborator
Author
|
Hey @masseelch, plz review again. 🥰 |
Collaborator
|
This is what I meant yes. Though I advise to let And we need to see if @a8m is willing to merge it :-) |
17b5b93 to
38452c0
Compare
Collaborator
Author
|
Updated PR with todofed, and unchanges other apps. |
a8m
approved these changes
Jan 7, 2022
Member
a8m
left a comment
There was a problem hiding this comment.
Looks good 🚀
Add minor style comments and a few thoughts.
giautm
commented
Jan 7, 2022
giautm
commented
Jan 7, 2022
giautm
commented
Jan 7, 2022
Co-authored-by: Ariel Mashraki <7413593+a8m@users.noreply.github.com>
Member
|
Thanks for the contribution @giautm ❤️ |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the EntGQL extension didn't load any GQLGen plugins. So, When I use Federations (it's a built-in GQLGen plugin), EntGQL complains about undefined
@keydirectives which will be defined by the plugin via code-mod.Current error
This PR loads built-in plugins from GQLGen, and also provides options to load third-party plugins.