Skip to content

/ closure-compiler

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String.fromCharCode optimization #3606

Open
kittenswolf opened this issue May 27, 2020 · 2 comments
Open

String.fromCharCode optimization #3606

kittenswolf opened this issue May 27, 2020 · 2 comments
Labels
P4 feat good first issue

Comments

@kittenswolf
Copy link

@kittenswolf kittenswolf commented May 27, 2020

I used: https://closure-compiler.appspot.com/home

Input code:
document.write(String.fromCharCode(115));

Expected output:
document.write("s")

Actual output:
document.write(String.fromCharCode(115));

I expected the String.fromCharCode function to be removed to just the resulting character.
@brad4d
Copy link
Contributor

@brad4d brad4d commented May 27, 2020

We'd certainly entertain a PR for this one, but it's unlikely to be a priority for us.
@brad4d brad4d added the P4 label May 27, 2020
@concavelenz
Copy link
Contributor

@concavelenz concavelenz commented Jun 22, 2020

@kittenswolf Can you provide a usecase where this would be valuable?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P4 feat good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@brad4d @concavelenz @kittenswolf
You can’t perform that action at this time.