Use test dependencies for test matrix#3421
Merged
mthalman merged 1 commit intodotnet:mainfrom Jan 20, 2022
Merged
Conversation
MichaelSimons
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes from dotnet/docker-tools#941 exposed an issue in the test matrix generation related to .NET Core 3.1 sdk images for Debian/Ubuntu. Those Dockerfiles are based on buildpack-deps and so they don't have a direct dependency on the runtime-related Dockerfiles. However, for testing purposes we want them tested together. To accomplish this, the manifest defines a customBuildLegGroup named
test-dependenciesthat causes the matrix generation to integrate these platforms for testing:dotnet-docker/manifest.json
Lines 3151 to 3159 in 69758fd
However, in the test stage of the build, this
test-dependenciescustomBuildLegGroup was not enabled. This led the matrix generation to include two separate test legs: one for the runtime-related Dockerfiles and one for the sdk Dockerfile. The test legs had the same name. Because of the changes in dotnet/docker-tools#941, this is now causing an exception.In reality, having the duplicate test legs names was not causing any tests from being excluded. We were still testing everything that should have been tested before. That's because the
--pathparameters of the test leg, which are different between the two test legs, aren't actually used by the test code; it's driven off the contents of the image info file that is passed as input. However, we still want to address the issue of duplicate leg names to ensure correctness.I've fixed this by setting the
testMatrixCustomBuildLegGroupArgspipeline parameter so thattest-dependenciesis included.