fix: endless loop in utf8_len while input is an invalid utf8 string#62
Merged
spacewander merged 5 commits intoapi7:masterfrom Jan 13, 2022
Merged
Conversation
membphis
approved these changes
May 5, 2021
Contributor
|
@Gerrard-YNWA do you have time to resolve the confilicts? After this, we are ready to merge this PR |
Gerrard-YNWA
force-pushed
the
fix/strlen-endless-loop
branch
from
ca38e0c to
a69e541
Compare
Contributor
Author
|
@membphis I have rebased the latest code but CI seems failed on install Linux Script step |
Contributor
|
We can upgrade luarocks to 3.8.0 via this action? |
Contributor
Author
Okay, I'll have a try. |
Contributor
Author
|
Hi @spacewander, CI passed now, plz take a look when you have time : ) |
membphis
approved these changes
Jan 13, 2022
Contributor
|
@Gerrard-YNWA |
Gerrard-YNWA
force-pushed
the
fix/strlen-endless-loop
branch
from
d1efabb to
0a181e7
Compare
Contributor
Author
|
@spacewander resolved : ) |
spacewander
approved these changes
Jan 13, 2022
Contributor
|
Merged. Thanks! |
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 13, 2022
See api7/jsonschema#62 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
4 tasks
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 13, 2022
See api7/jsonschema#62 Signed-off-by: spacewander <spacewanderlzx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr references the implementation of the
utf8.RuneCountInStringin golang, takes invalid utf8 strings in consideration and treats them as single bytes. close #61