Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle CI: Run DevTools Playwright e2e tests #23019

Merged
merged 1 commit into from Jan 4, 2022
Merged

Circle CI: Run DevTools Playwright e2e tests #23019

merged 1 commit into from Jan 4, 2022
+190 −0

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Dec 22, 2021 •
edited

Let's run the new DevTools e2e tests on Circle CI. They seem solid but if this turns out to be flaky or cause problems we can disable them.

Resolves #22646.

Successful run

Screen.Recording.2021-12-22.at.2.08.20.PM.mov

Failed run

Screen.Recording.2021-12-22.at.2.10.00.PM.mov
@bvaughn bvaughn requested review from jstejada and lunaruan Dec 22, 2021
@sizebot
Copy link

@sizebot sizebot commented Dec 22, 2021 •
edited

Comparing: bcd24a6...2f05c55

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.52 kB 129.52 kB = 41.53 kB 41.53 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.65 kB 134.65 kB = 43.01 kB 43.01 kB
facebook-www/ReactDOM-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB
facebook-www/ReactDOM-prod.modern.js = 417.45 kB 417.45 kB = 77.06 kB 77.06 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 2f05c55

@bvaughn bvaughn force-pushed the devtools-run-e2e-tests-in-ci branch from 6d692d5 to a2e1035 Dec 22, 2021
@bvaughn bvaughn changed the title Run DevTools e2e tests on Circle CI Circle CI: Run DevTools Playwright e2e tests Dec 22, 2021
@bvaughn bvaughn force-pushed the devtools-run-e2e-tests-in-ci branch from a2e1035 to e83afab Dec 22, 2021
@bvaughn
Copy link
Contributor Author

@bvaughn bvaughn commented Dec 22, 2021 •
edited

Looks like the new command is mostly working on Circle CI, except for a browser+environment issue:

 browserType.launch: Executable doesn't exist at /home/circleci/.cache/ms-playwright/chromium-930007/chrome-linux/chrome
 ╔═════════════════════════════════════════════════════════════════════════╗
 ║ Looks like Playwright Test or Playwright was just installed or updated. ║
 ║ Please run the following command to download new browsers:              ║
 ║                                                                         ║
 ║     npx playwright install                                              ║
 ║                                                                         ║
 ║ <3 Playwright Team                                                      ║
 ╚═════════════════════════════════════════════════════════════════════════╝

Maybe this is related to the version of Node our tests are running on? microsoft/playwright#4033

Although judging from the output of our setup job, we're using a new enough version (v14.17.6):

#!/bin/bash -eo pipefail
node --version
v14.17.6
CircleCI received exit code 0

Let me try to add a specific playwright install step to the CI task...

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 2b8b694d0..60c5ed2e0 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -212,6 +212,9 @@ jobs:
       - run:
           name: Install Packages
           command: yarn --frozen-lockfile --cache-folder ~/.cache/yarn
+      - run:
+          name: Playwright install
+          command: npx playwright install
       - run:
           environment:
             RELEASE_CHANNEL: experimental

@bvaughn bvaughn force-pushed the devtools-run-e2e-tests-in-ci branch from e83afab to bcca4cf Dec 22, 2021
@bvaughn bvaughn force-pushed the devtools-run-e2e-tests-in-ci branch from bcca4cf to 2f05c55 Dec 22, 2021
@bvaughn
Copy link
Contributor Author

@bvaughn bvaughn commented Dec 22, 2021

Yay it worked! 🥳

@bvaughn bvaughn mentioned this pull request Dec 22, 2021
Closed
@bvaughn bvaughn merged commit 9724e18 into facebook:main Jan 4, 2022
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstejada jstejada

@lunaruan lunaruan

Assignees
No one assigned
Labels
CLA Signed Component: Developer Tools React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Add e2e tests for inline package
4 participants
@bvaughn @sizebot @jstejada @facebook-github-bot