Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofreading and fix cross-document link #103

Merged
merged 1 commit into from Sep 29, 2021
Merged

Proofreading and fix cross-document link #103

merged 1 commit into from Sep 29, 2021

Conversation

Copy link
Contributor

@dimhotepus dimhotepus commented Sep 22, 2021

  • Fix typos.
  • Fix small grammar mistakes.
  • Fix link to std::make_unique, as it is absolute one.

@AnthonyCalandra
Copy link

@AnthonyCalandra AnthonyCalandra commented Sep 23, 2021

Hi, change looks good. Can you also make the same edit in README.md? Thanks!

Copy link
Owner

@AnthonyCalandra AnthonyCalandra left a comment

Make the same change to README.md.

@dimhotepus dimhotepus changed the title Fix typo in Cpp20 Proofreading and fix cross-document link Sep 29, 2021
@dimhotepus dimhotepus requested a review from AnthonyCalandra Sep 29, 2021
Copy link
Owner

@AnthonyCalandra AnthonyCalandra left a comment

Thanks for submitting all these changes! They were very good.

Since I don't want top post a comment for every instance of this error I'll post here: the changes where you change "an" to "a" before words like "rvalue" are actually incorrect changes. The reason for this is because you don't use "a" before words that have vowel sounds at the beginning of their pronunciation. For example, "rvalue" sounds like "are value" when you say it aloud, and since "are" begins with a vowel it should be proceeded by "an". See here or here. Same reasoning applies to "lvalue" because it's pronounced as "elle value".

CONTRIBUTING.md Outdated Show resolved Hide resolved
@dimhotepus
Copy link
Author

@dimhotepus dimhotepus commented Sep 29, 2021

Thanks for submitting all these changes! They were very good.

Since I don't want top post a comment for every instance of this error I'll post here: the changes where you change "an" to "a" before words like "rvalue" are actually incorrect changes. The reason for this is because you don't use "a" before words that have vowel sounds at the beginning of their pronunciation. For example, "rvalue" sounds like "are value" when you say it aloud, and since "are" begins with a vowel it should be proceeded by "an". See here or here. Same reasoning applies to "lvalue" because it's pronounced as "elle value".

Fixed. Today I definitely learned something new.

@dimhotepus dimhotepus requested a review from AnthonyCalandra Sep 29, 2021
Copy link
Owner

@AnthonyCalandra AnthonyCalandra left a comment

Looks good to me. Thanks!

@AnthonyCalandra AnthonyCalandra merged commit c72f279 into AnthonyCalandra:master Sep 29, 2021
@dimhotepus dimhotepus deleted the patch-1 branch Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants