Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for resource JSON marshalling #55

Open
willnorris opened this issue Sep 5, 2013 · 30 comments
Open

add tests for resource JSON marshalling #55

willnorris opened this issue Sep 5, 2013 · 30 comments

Comments

@willnorris
Copy link
Collaborator

@willnorris willnorris commented Sep 5, 2013

see 5f1c20a for more details

@palash25
Copy link
Contributor

@palash25 palash25 commented Dec 30, 2018

Hi @willnorris I would like to take this up. I will start with projects_test.go will make a PR soon.

@palash25
Copy link
Contributor

@palash25 palash25 commented Dec 30, 2018

This can be labeled a good-first-issue since beginners can work on writing test for different resources at the same time.

@jamesgeorge007
Copy link

@jamesgeorge007 jamesgeorge007 commented Jan 25, 2019

@palash25 @gmlewis I would like to work on what is left further. Also, I'm not familiar with the code-base.
It would be great if you could guide me on resolving this issue 👍

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Jan 25, 2019

Hi @jamesgeorge007! Thank you for your interest in helping out.

First, you will want to read our CONTRIBUTING.md guide.

Second, you will want to get familiar with the code by reading through it and trying it out.

Then, I suggest following the link to the original issue where it is explained what is needed in more detail.

Thanks again, and I look forward to seeing PRs from you.

@palash25
Copy link
Contributor

@palash25 palash25 commented Jan 25, 2019

@jamesgeorge007 hi 👋 just take a look at my commit referenced here and you will get the idea how to write the JSON test for different resources. Once it is clear just pick a resource that hasn't been covered by the tests and write a unit test for it 😄

@jamesgeorge007
Copy link

@jamesgeorge007 jamesgeorge007 commented Jan 25, 2019

@palash25 As mentioned above I'm not familiar with the code-base. It would be great if you could suggest on what test case is to be written specifically.
Thank you

@palash25
Copy link
Contributor

@palash25 palash25 commented Jan 25, 2019

As mentioned above I'm not familiar with the code-base.

I have mentioned how to get familiar with the codebase. It would be great if you could re-read my previous comment, and the referenced issues and the PRs. 😄 and then follow the steps accordingly

@vaibhavsingh97
Copy link
Contributor

@vaibhavsingh97 vaibhavsingh97 commented Feb 26, 2019

@jamesgeorge007 Are you working on this issue? I would like to work on it 😅
I would love to start with pulls_comments_test.go

@palash25
Copy link
Contributor

@palash25 palash25 commented Feb 26, 2019

@vaibhavsingh97 I think there are multiple resources that need the JSON marhsalling test so if you start with pulls_comments_test.go I don't think there will be any problem since other contributors can pick up the left out resources. 👍

sgarciac added a commit to sgarciac/go-github that referenced this issue Oct 8, 2019
sgarciac added a commit to sgarciac/go-github that referenced this issue Oct 8, 2019
sgarciac added a commit to sgarciac/go-github that referenced this issue Oct 8, 2019
sgarciac added a commit to sgarciac/go-github that referenced this issue Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet