Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Add test step 'the user count of group should not be displayed #39809

Merged
merged 1 commit into from Feb 19, 2022

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 19, 2022

Description

PR #39721 changed the behavior of the groups on the user management page. If the group is an LDAP group, or for whatever reason the group member count is zero or not available, then the count is not displayed at all.

As a result, some existing tests in user_ldap are failing and need to be adjusted. The group member count is no longer displayed.

To help adjust the scenarios mention in the related issue, this PR adds a test step to core:

@Then /^the user count of group "([^"]*)" should not be displayed on the webUI$/

That step can be used in user_ldap test scenarios, or anywhere that it is appropriate.

Related Issue

owncloud/user_ldap#716

How Has This Been Tested?

CI

I have tried the step locally and it works. After this PR is merged to core, I will make a PR to user_ldap that adjusts the user_ldap test scenarios.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE
@phil-davis phil-davis self-assigned this Feb 19, 2022
@phil-davis phil-davis force-pushed the user-count-should-not-exist branch from 6b1f597 to 32e6a71 Feb 19, 2022
@phil-davis phil-davis changed the title [tests-only] Add test step 'the user count of group should not exist [tests-only] Add test step 'the user count of group should not be displayed Feb 19, 2022
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Feb 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 196fe0c into master Feb 19, 2022
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the user-count-should-not-exist branch Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants