kubernetes / minikube Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw Docker is nearly out of disk space errors if more than X GB of disk space available
#12761
Comments
|
Hi @HarHarLinks, thanks for reporting this issue, while this is far from a normal use case I agree that we can easily implement a size check to not show errors if space is greater than XGB. Also, I think we should take the |
Docker is nearly out of disk space errors if more than X GB of disk space available
|
@spowelljr I'd like to work on this issue if possible. Since I'm a new contributor to this project, would it perhaps be possible to point out some of the code/files I should have a look at? |
|
Hi @F1ko, to assign the issue to yourself comment Here's the link to the function where the errors are thrown: https://github.com/kubernetes/minikube/blob/master/pkg/minikube/machine/start.go#L212. A good number to check for is 20GB, so if the user has less than 85% or 99% space available but greater than 20GB then don't throw any errors or warnings. We should also check if the minikube/cmd/minikube/cmd/start.go Line 154 in 91c9af3
And one last thing is in the error messages, we should notify the user that if they can pass the |
|
Thanks a lot @spowelljr ! /assign |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
going to remove the frozen lifecycle since there are new commits being pushed to the PR unless there is another reason to freeze this issue? (@spowelljr ) /remove-lifecycle frozen |
|
Frozen prevents it from going stale |
|
Has this issue been worked on? I will like to take it up. |
|
Yes, it actually is done already, I am just waiting for a final review. Anything I need to do in that regard or just wait @spowelljr ? |
I have just cleared out some space so minikube would even start at "100%" used disk - which in this case is several terabytes large and still had several 100GB free.
It is now warning me that "Docker is nearly out of disk space" at 98% which equals 843GB currently available space which is quite frankly ridiculous.
The text was updated successfully, but these errors were encountered: