Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw Docker is nearly out of disk space errors if more than X GB of disk space available #12761

Closed
HarHarLinks opened this issue Oct 22, 2021 · 9 comments · Fixed by #13630
Closed

Comments

@HarHarLinks
Copy link

@HarHarLinks HarHarLinks commented Oct 22, 2021

I have just cleared out some space so minikube would even start at "100%" used disk - which in this case is several terabytes large and still had several 100GB free.
It is now warning me that "Docker is nearly out of disk space" at 98% which equals 843GB currently available space which is quite frankly ridiculous.

@spowelljr
Copy link
Collaborator

@spowelljr spowelljr commented Oct 26, 2021

Hi @HarHarLinks, thanks for reporting this issue, while this is far from a normal use case I agree that we can easily implement a size check to not show errors if space is greater than XGB. Also, I think we should take the --force flag into consideration so someone can completely bypass the check if they want.

@spowelljr spowelljr changed the title Tie out of disk space warning to actual disk space instead of percentage Don't throw Docker is nearly out of disk space errors if more than X GB of disk space available Oct 26, 2021
@F1ko
Copy link
Contributor

@F1ko F1ko commented Oct 26, 2021

@spowelljr I'd like to work on this issue if possible. Since I'm a new contributor to this project, would it perhaps be possible to point out some of the code/files I should have a look at?

@spowelljr
Copy link
Collaborator

@spowelljr spowelljr commented Oct 26, 2021

Hi @F1ko, to assign the issue to yourself comment /assign.

Here's the link to the function where the errors are thrown: https://github.com/kubernetes/minikube/blob/master/pkg/minikube/machine/start.go#L212.

A good number to check for is 20GB, so if the user has less than 85% or 99% space available but greater than 20GB then don't throw any errors or warnings. We should also check if the --force flag is passed and if it is don't do these checks at all, example:

if viper.GetBool(force) {

And one last thing is in the error messages, we should notify the user that if they can pass the --force to skip the check if they want to.

@F1ko
Copy link
Contributor

@F1ko F1ko commented Oct 26, 2021

Thanks a lot @spowelljr !

/assign

@k8s-triage-robot
Copy link

@k8s-triage-robot k8s-triage-robot commented Jan 24, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@F1ko
Copy link
Contributor

@F1ko F1ko commented Jan 30, 2022

going to remove the frozen lifecycle since there are new commits being pushed to the PR

unless there is another reason to freeze this issue? (@spowelljr )

/remove-lifecycle frozen

@spowelljr
Copy link
Collaborator

@spowelljr spowelljr commented Jan 31, 2022

Frozen prevents it from going stale

@mayur-tolexo
Copy link

@mayur-tolexo mayur-tolexo commented Feb 8, 2022

Has this issue been worked on? I will like to take it up.

@F1ko
Copy link
Contributor

@F1ko F1ko commented Feb 8, 2022

Yes, it actually is done already, I am just waiting for a final review.

Anything I need to do in that regard or just wait @spowelljr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

6 participants