Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Importer] Wrap the VFS passed to Clang with an overlay FS instead" #41636

Merged
merged 1 commit into from Mar 3, 2022
Merged

Revert "[Importer] Wrap the VFS passed to Clang with an overlay FS instead" #41636

merged 1 commit into from Mar 3, 2022
+2 −55

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented Mar 2, 2022

Reverts #41546.

OverlayFileSystem does not store a separate CWD and instead calls setCurrentWorkingDirectory on all filesystem's it contains. We don't want Clang to be able to set Swift's CWD.

@bnbarham bnbarham requested review from akyrtzi and JDevlieghere Mar 2, 2022
@bnbarham
Copy link
Contributor Author

@bnbarham bnbarham commented Mar 2, 2022

@swift-ci please test

akyrtzi
akyrtzi approved these changes Mar 2, 2022
View changes
@bnbarham bnbarham merged commit f93bc64 into main Mar 3, 2022
5 checks passed
@bnbarham bnbarham deleted the revert-41546-use-overlay-fs-instead branch Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akyrtzi akyrtzi

@JDevlieghere JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bnbarham @akyrtzi