Skip to content

Comments

fix(textarea): add vertical resizing#4510

Closed
im-adithya wants to merge 4 commits intouber:masterfrom
im-adithya:task-autosize-textarea
Closed

fix(textarea): add vertical resizing#4510
im-adithya wants to merge 4 commits intouber:masterfrom
im-adithya:task-autosize-textarea

Conversation

@im-adithya
Copy link
Contributor

Fixes #4054

Description

Changed resize: none to 'resize: vertical` so as to enable auto-sizing in textarea component

Scope

Patch: Bug Fix

@vercel
Copy link

vercel bot commented Sep 10, 2021

@im-adithya is attempting to deploy a commit to the Uber UI Platform Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/uber-ui-platform/baseweb/HwihsXqCQrUxdkLqZ3t1etbiKmP3
✅ Preview: https://baseweb-git-fork-im-adithya-task-autosi-6fa2c1-uber-ui-platform.vercel.app

@UberOpenSourceBot
Copy link
Contributor

Visual changes were detected on this branch. Please review the following PR containing updated snapshots: im-adithya#2

@williamernest
Copy link
Contributor

Ideally, we don't want this behavior on our default component so this change should be behind a resize prop and it's probably best to implement min/max rows with this change as well.

@im-adithya
Copy link
Contributor Author

Sure! I'll change this to a prop then!
But how do we set max rows for a textarea component? (or is it max-height that you are referring to indirectly?)
Because the existing rows prop would kinda set the minimum rows (which is subject to resize unless min-height and max-height are set...)

@im-adithya im-adithya force-pushed the task-autosize-textarea branch from fb3cfde to 17d22b5 Compare September 15, 2021 19:55
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17d22b5:

Sandbox Source
Basic usage Configuration

@im-adithya
Copy link
Contributor Author

Screenshot from 2021-09-16 01-29-57

Done @williamernest! Please review :)

@chasestarr
Copy link
Collaborator

Thank you for putting up this diff. We've added this feature here #5103

@chasestarr chasestarr closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Text area with auto-sizing

4 participants