feat(rating): add rating kind secondary and primary#4729
Closed
ProjectBarks wants to merge 5 commits intouber:masterfrom
Closed
feat(rating): add rating kind secondary and primary#4729ProjectBarks wants to merge 5 commits intouber:masterfrom
ProjectBarks wants to merge 5 commits intouber:masterfrom
Conversation
ProjectBarks
requested review from
chasestarr,
lhbrennan,
tajo and
williamernest
as code owners
|
@williamernest is attempting to deploy a commit to the Uber UI Platform Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b6230d:
|
Contributor
|
Visual changes were detected on this branch. Please review the following PR containing updated snapshots: ProjectBarks#1 |
test(vrt): update visual snapshots for ProjectBarks:master [skip ci]
Collaborator
|
Thank you for contributing. We've updated rating star colors to black since this PR was opened. Please re-assess and open again if this is something we still want |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a secondary style to ratings, splitting the two kinds by
KINDconstants.Description
Have seen use cases where base could warrant a secondary style especially for a read-only mode.
Scope
Minor: New Feature