chinmaygarde
Follow
chinmaygarde
Follow
Pinned
1,176 contributions in the last year
Less
More
Activity overview
Contribution activity
March 2022
Created 26 commits in 3 repositories
Created a pull request in flutter/engine that received 25 comments
Add a display list op to clear the transformation stack.
This allows for the implementation of the DisplayListCanvasRecoder::didSetM44. Instead of another operation that clears the transformation stack al…
+46
−9
•
25
comments
Opened 29 other pull requests in 3 repositories
flutter/impeller
1
open
18
merged
2
closed
- Use display list images.
- Batch all draw calls in the entire text frame.
- Draw all glyphs in a text run using a single draw call.
- Use 8bpp glyph atlases.
- Add support for instanced rendering and shader storage buffers.
- Implement impeller::DisplayListDispatcher::drawTextBlob.
- Forward blend mode from the dispatchers drawColor call.
- Add ClearContents to apply specified contents to the entire render target.
- Insert an implicit MoveTo if components are added to a path directly.
- Implement DisplayListDispatcher::transformReset.
- Add cast necessary on 32-bit arm builds.
- Fix issues with constexpr correctness.
- Fix loop-range-construct warnings added in newer versions of Clang.
- Loop range construct
- Only depend on FML for tracing when building executables.
- Fix diagnostic on iOS simulators.
- Document GN rules and make targets that cannot be built on the platform be no-ops.
- Fix top-level build group to not include the compiler and fixup headers.
- Add a script that checks that all source files have a valid license block.
- Move impeller::Comparable to //impeller/base.
- Add LICENSE file.
flutter/engine
1
open
5
merged
Reviewed 54 pull requests in 3 repositories
flutter/impeller
28 pull requests
- Wire up stroke cap/join/miter limit display list ops
- Premultiply gradient colors
- Render glyphs at the correct resolution with respect to the current transform
- Make the filter DAG render all textures at the correct resolution
- Separate filters into different TUs
- switch dispatcher methods to new DlImageFilter objects
- Add blend mode setting to Entity, Aiks paint, and the dispatcher
- Add blend filter support for advanced blends
- Add directional + 2D gaussian blur
- Use new DlBlendMode object
- update the linear gradient code to the new accessor names
- Add remaining simple blend modes
- Use new DlColorSource objects
- Document GN rules and make targets that cannot be built on the platform be no-ops.
- Chainable texture filters
- Correct default blend mode, fix solid stroke shader to respect premultiplied source colors
- Prevent hanging when running back-to-back playground tests
- [tessellator]Expose and document smoothing approximation via the C/Dart API. Minor refactor of tessellator to supply fill type to method rather than to object.
- Correct polyline bounds test
- Add a script that checks that all source files have a valid license block.
- Remove FML dependency on geometry, tessellator
- Add color premultiply/unpremultiply
- Add pipeline blend modes & demo
- Fix ScalarNearlyEqual test
- Move Contents classes into separate translation units
- Some pull request reviews not shown.
flutter/engine
23 pull requests
- Explicitly cast fuchsia.io constants to uint32_t
- Add gclient parser.
- ios text input plugin ignores selection calls when interactive selection is disabled
- [iOS] Ensure the keyboard bottom inset is zero when keyboard dismiss.
- Make sure that 'BeginFrame' and 'EndFrame' of the 'ExternalViewEmbedder' are paired
- Add DlImageFilter objects
- [examples] Ignore myapp from run.sh.
- [iOS] Fixes state restoration not work
- Remove config.locale usages
- override delete operators in DlGradient classes
- Optionally specify the target dir in tools/gn
- Disable several tests due to flakiness
- Add a display list op to clear the transformation stack.
- Roll buildroot to a379462.
- Reland: Remove unused Settings::ToString. (#8642)
- Add DlColorSource objects to hold information for SkShaders
- Make sure the secondary vsync callback is called after the vsync callback
- Support stencil buffers on OpenGL for Windows and Android
- Animator stopped notifying delegate to render when pipeline is not empty
- Fixed image generator registry usage with spawn.
- Add no-prebuilt-dart-sdk support to fuchsia build
- Windows: Fix plugin destruction
- [android] Give the shared engine app a chance to take control of application lifecycle state events.
flutter/buildroot
3 pull requests
Created an issue in flutter/flutter that received 4 comments
Make the clang-tidy presubmit check understand generated files.
An instance of the failure is here. Impeller references files that generated at built time contain reflected shader information for creating pipeli…
4
comments
Opened 5 other issues in 1 repository
flutter/flutter
2
open
3
closed
- Remove the toggle to disable display lists and delete dead code.
- Use the clang toolchain in buildroot for iOS simulator ARM64 builds.
-
[impeller]
GeometryTest.PolylineGetContourOutOfBoundsAbortsfails in profile mode. - [Impeller] Implement an impeller::Contents subclass allows manipulating one or more input images into a single output image.
- [Impeller] Support pipeline variants for setting blend modes on individual commands.