cockroachdb / cockroach Public

75970: backup: use separate incremental directory by default r=benbardin a=benbardin

backup: use separate incremental directory by default

Previously support was added to optionally cause interactions with a backup to search for its incremental layers in an alternative path.

This change expands that behavior, adding a default path for incremental layers to interactions with backups in a collection. This new default is the '/incrementals' subdirectory of the collection root. This default may be overridden by the prevoiusly-added incremental_storage parameter. This default means that an operator can easily apply different policies to incremental backups retroactively. This behavior also provides an alternative to passing matching incremental_storage parameters to every interaction with those backups, which improves usability.

During the upgrade, when interacting with existing backups, this behavior remains disabled.
After the upgrade, if an existing chain of incremental backups exists in the old default collection, this behavior also remains disabled.
Also after the upgrade, if no such chain exists, or the chain exists in the new default location, the new behavior will be enabled.

Release note (enterprise change): Incremental backups created by BACKUP TO LATEST IN are now stored by default under the path 'incrementals' within the backup collection, rather than under each backup's path. This enables easier management of cloud-storage provider policies specifically applied to incremental backups.

Release justification: This feature is very well-tested, and the code refactoring makes it more verifiably correct.

77571:  ui: Fix Reset SQL stats in Statements and Transactions pages  r=jocrl a=jocrl

Fixes #77546

Previously, the "Reset SQL stats" button on Statements and Transactions pages
was broken in different ways in DB Console and CC Console.

In DB Console, clicking the "Reset SQL stats" button on Statements or
Transactions pages causes the loading spinner to spin infinitely, and the table
does not reload. The stats are indeed reset in the backend, and so this can be
fixed by manually refreshing the page.

In CC Console, clicking the "Reset SQL stats" button on Statements or
Transactions pages causes the stats to correctly reset in the backend, and the
table to correctly reload. However, the table is reloaded without respecting
the currently selected time.

Both were ultimately caused because clicking the button did not pass a request
object specifying the currently selected start and end times. The bug
manifested differently in the two environments because of differing
implementations of their sagas.

Now, this has been fixed and the "Reset SQL stats" button works correctly. In DB
Console, the `requestSQLStatsSaga` saga previously called one of two API
functions, `getCombinedStatements` and `getStatements`, depending on whether a
request object was passed. We do not have a situation where we do not want to
pass the start and end times, so the `getStatements` path which did not take a
request object has been removed. Were possible, typing has been made stricter
to require the request object.

The change in `rangeSelector.module.scss` fixes a bug where equally specific CSS
selectors competed and won out differently depending on quirks of compilation.
The unrelated Javascript changes in this PR thus caused the height of
`timeScaleDropdown` to break, necessitating the changes in
`rangeSelector.module.scss`. To be clear, the height was not broken before this
commit; it was caused by the Javascript changes in this commit.

Release note (ui): Fixed a bug where the clicking the "Reset SQL stats" button
on Statements and Transactions pages caused, in DB Console, an infinite loading
spinner and, in CC Console, the statements/transactions table to be reloaded
without limiting to the time range that the user had selected. The button now
correctly reloads the table according to the selected time in both DB Console
and CC Console.

Release justification: Category 2, UI bug fix

Co-authored-by: Ben Bardin <bardin@cockroachlabs.com>
Co-authored-by: Josephine Lee <josephine@cockroachlabs.com>