Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

srcset values gets striped, when defined more than one. #2891

Open
selodev opened this issue Apr 23, 2021 · 1 comment
Open

srcset values gets striped, when defined more than one. #2891

selodev opened this issue Apr 23, 2021 · 1 comment
Labels
Awaiting Reply Good First Issue Repro: No Resolution: Needs Investigation

Comments

@selodev
Copy link

@selodev selodev commented Apr 23, 2021 •
edited

example:

<img src="..." srcSet="img.jpg 200w, imgtwo.jpg 300w, imgthree.jpg 400w">

becomes:

<img src="..." srcSet="img.jpg?v=1234567891 200w">

stencil/src/compiler/prerender/prerender-optimize.ts

Line 327 in 45388e9

const hashPageStateAstAssets = async (

@ionitron-bot ionitron-bot bot added the triage label Apr 23, 2021
@splitinfinities
Copy link
Contributor

@splitinfinities splitinfinities commented Nov 9, 2021

Is this still the case in latest versions of Stencil? Would love to have a quick reproduction repo that we can test against.

@splitinfinities splitinfinities added Repro: No Good First Issue Bug: Needs Validation Awaiting Reply labels Nov 9, 2021
@ionitron-bot ionitron-bot bot removed the triage label Nov 9, 2021
@rwaskiewicz rwaskiewicz added Resolution: Needs Investigation and removed Feature: Renderer labels Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Reply Good First Issue Repro: No Resolution: Needs Investigation
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@splitinfinities @rwaskiewicz @selodev