Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Bump Uvicorn max range to 0.17.x #4680

Closed
wants to merge 1 commit into from

Conversation

pedropozzobon
Copy link

@pedropozzobon pedropozzobon commented Mar 11, 2022

I believe this is important to be done due to:

encode/uvicorn#1400
MagicStack/httptools#76

@dynalz
Copy link

@dynalz dynalz commented Mar 13, 2022

New versions of Uvicorn are not compatible with FastAPI, doing a few tests websockets stop working all together.

@pedropozzobon
Copy link
Author

@pedropozzobon pedropozzobon commented Mar 13, 2022

@dynalz Can you give more info on this? I've just run the three examples in https://fastapi.tiangolo.com/advanced/websockets/, using the following environment and they seem to be working:

env-example

@Kludex
Copy link
Sponsor Contributor

@Kludex Kludex commented Mar 19, 2022

New versions of Uvicorn are not compatible with FastAPI, doing a few tests websockets stop working all together.

An issue on uvicorn on how to reproduce it is appreciated...

@levrik
Copy link

@levrik levrik commented Mar 30, 2022

@dynalz We're using FastAPI with manually installed Uvicorn, so aren't affected by the limitations of the all extra here. We are running Uvicorn 0.17.x for some time in production now. No issues so far.

@odiseo0
Copy link

@odiseo0 odiseo0 commented Apr 4, 2022

Same here, installed Uvicorn (standard) separately from FastAPI and it's doing fine, currently in 0.17.6

@tiangolo
Copy link
Owner

@tiangolo tiangolo commented Apr 17, 2022

Thanks @pedropozzobon! And thanks for the conversation everyone.

This was included as part of #4803, and it will be available in FastAPI 0.75.2 in a couple of hours, so I'll close this one now.

But thanks for the effort @pedropozzobon! 🍰

@tiangolo tiangolo closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants