-
Notifications
You must be signed in to change notification settings - Fork 50.5k
Fix:Fixed css Label #23134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix:Fixed css Label #23134
Conversation
|
Comparing: 3dc41d8...f96a0be Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Jassi10000-zz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Biki-das
Thanks for your contribution
It's valid but I would suggest to include some screenshot / supporting material to show the old and new look of the component so that it's easy for us also to review that what exactly the new outlook is
@Jassi10000 dont give useless review, this pr just fix the css label, which was put under single quotes, which is not a valid css syntax that's it. |
|
@Biki-das |
|
you are deprecating the journey, react is quite heavy on pr, i am sorry but that review was useless |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
the display property should be :-
display:inline-block