Skip to content

Conversation

@Biki-das
Copy link
Contributor

@Biki-das Biki-das commented Jan 18, 2022

  display: 'inline-block';
  margin-left: 20px;
}

the display property should be :- display:inline-block

@sizebot
Copy link

sizebot commented Jan 18, 2022

Comparing: 3dc41d8...f96a0be

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 129.52 kB 129.52 kB = 41.53 kB 41.53 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 134.65 kB 134.65 kB = 43.01 kB 43.01 kB
facebook-www/ReactDOM-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB
facebook-www/ReactDOM-prod.modern.js = 417.45 kB 417.45 kB = 77.06 kB 77.06 kB
facebook-www/ReactDOMForked-prod.classic.js = 427.76 kB 427.76 kB = 78.53 kB 78.53 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against f96a0be

Copy link

@Jassi10000-zz Jassi10000-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Biki-das
Thanks for your contribution
It's valid but I would suggest to include some screenshot / supporting material to show the old and new look of the component so that it's easy for us also to review that what exactly the new outlook is

@Biki-das
Copy link
Contributor Author

@Biki-das Thanks for your contribution It's valid but I would suggest to include some screenshot / supporting material to show the old and new look of the component so that it's easy for us also to review that what exactly the new outlook is

@Jassi10000 dont give useless review, this pr just fix the css label, which was put under single quotes, which is not a valid css syntax that's it.

@Jassi10000-zz
Copy link

@Biki-das
I got the changes just asked for a screenshot of : how now the updated component looks like
and gentleman , please mind your words , respect the developer community

@Biki-das
Copy link
Contributor Author

you are deprecating the journey, react is quite heavy on pr, i am sorry but that review was useless

@github-actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
@github-actions
Copy link

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@github-actions github-actions bot closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Resolution: Stale Automatically closed due to inactivity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants