Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate Python 3.7 #19017

Merged
merged 4 commits into from Mar 14, 2022
Merged

chore: Deprecate Python 3.7 #19017

merged 4 commits into from Mar 14, 2022

Conversation

john-bodley
Copy link
Contributor

@john-bodley john-bodley commented Mar 3, 2022 •
edited

SUMMARY

As titled.

Note as part of this PR I tried to add support for 3.10 however this is more work, i.e., beyond bumping numpy we would also need to relax the constraints for a number of packages defined in setup.py, i.e., the current version bound for pyarrow, sqlalchemy, etc. do not support Python 3.10.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: #18904
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--deprecate-py37-add-py310 branch from f3174f9 to 42678bd Compare Mar 3, 2022
john-bodley
john-bodley reviewed Mar 3, 2022
View changes
.github/workflows/superset-python-integrationtest.yml Outdated
@@ -80,7 +80,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.8, 3.9]
python-version: ["3.8", "3.9", "3.10"]
Copy link
Contributor Author

@john-bodley john-bodley Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without quotes, YAML interprets 3.10 as a number i.e., 3.1 and thus I felt it was prudent to explicitly define all versions as strings and not numbers.

@john-bodley john-bodley force-pushed the john-bodley--deprecate-py37-add-py310 branch from 42678bd to a60537a Compare Mar 3, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 3, 2022
@john-bodley john-bodley force-pushed the john-bodley--deprecate-py37-add-py310 branch from a60537a to b68b92c Compare Mar 3, 2022
john-bodley
john-bodley reviewed Mar 3, 2022
View changes
requirements/base.txt Outdated
@@ -162,7 +162,7 @@ multidict==5.1.0
# via
# aiohttp
# yarl
numpy==1.21.1
numpy==1.22.2
Copy link
Contributor Author

@john-bodley john-bodley Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed to be bumped to resolve numpy/numpy#19033. Note this was bumped by deleting lines 165–168 and running pip-compile-multi --no-upgrade.

@john-bodley john-bodley changed the title chore: Deprecate Python 3.7 and add support for Python 3.10 chore: Deprecate Python 3.7 Mar 3, 2022
@john-bodley john-bodley force-pushed the john-bodley--deprecate-py37-add-py310 branch from b68b92c to 21e2fcf Compare Mar 3, 2022
@pull-request-size pull-request-size bot added size/S and removed size/M labels Mar 3, 2022
@john-bodley john-bodley force-pushed the john-bodley--deprecate-py37-add-py310 branch from 21e2fcf to 6fc879e Compare Mar 3, 2022
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 3, 2022
villebro
villebro reviewed Mar 4, 2022
View changes
Copy link
Member

@villebro villebro left a comment

Thanks for taking this on! Can you also update the docs to reflect this (remove the reference to 3.7 and add 3.9): https://github.com/apache/superset/blob/master/docs/docs/contributing/local-backend.mdx

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 7, 2022
@codecov
Copy link

@codecov codecov bot commented Mar 7, 2022 •
edited

Codecov Report

Merging #19017 (db429fa) into master (a37a4ed) will not change coverage.
The diff coverage is n/a.

❗ Current head db429fa differs from pull request most recent head e14c428. Consider uploading reports for the commit e14c428 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19017   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1645     1645           
  Lines       63515    63515           
  Branches     6464     6464           
=======================================
  Hits        42250    42250           
  Misses      19593    19593           
  Partials     1672     1672
Flag Coverage Δ
hive 52.59% <ø> (ø)
mysql 81.82% <ø> (ø)
postgres 81.87% <ø> (ø)
presto 52.44% <ø> (ø)
python 82.30% <ø> (ø)
sqlite 81.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37a4ed...e14c428. Read the comment docs.

@john-bodley
Copy link
Contributor Author

@john-bodley john-bodley commented Mar 10, 2022

@villebro I've addressed your comment.

villebro
villebro approved these changes Mar 11, 2022
View changes
Copy link
Member

@villebro villebro left a comment

LGTM 🐍

suddjian
suddjian approved these changes Mar 11, 2022
View changes
Copy link
Member

@suddjian suddjian left a comment

Thanks! 🎉

@john-bodley john-bodley merged commit e3e03d2 into apache:master Mar 14, 2022
23 checks passed
@john-bodley john-bodley deleted the john-bodley--deprecate-py37-add-py310 branch Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suddjian suddjian

@villebro villebro

@etr2460 etr2460

Assignees
No one assigned
Labels
risk:breaking-change size/S v2.0
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-bodley @suddjian @villebro