Script to mail regular issue summaries to typing-sig #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apart from a couple of things LGTM:
|
hauntsaninja
reviewed
Nov 12, 2021
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
See my comment above:
|
|
I've now set up a cron job that executes this script every Monday morning. Let's see whether this get through tomorrow. |
srittau
added
the
topic: maintenance
Use a constant for the label
Akuli
reviewed
Nov 21, 2021
scripts/typing-summary.py
Outdated
| s += "The following issues and pull requests were opened last week: \n\n" | ||
| s += "".join(generate_issue_text(issue) for issue in new) | ||
| s += "\n---------------------------------------------------\n\n" | ||
| if len(changed) >= 0: |
There was a problem hiding this comment.
Maybe these should be >, so that they don't run every time.
|
Ping. This has now been officially used for a few weeks. I think we should merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Example output (with cheated "since" date, since last week I touched all issues):
This script would be run once a week as a cron job. Unfortunately it seems that we can't mail directly from GitHub Actions (at least not without a mail server configured for it), but I can set up a cron job on a company server.
One possible caveat: It's possible the Python mail server will reject the mail with a python.org-From from a remote web server, in which case we need to change the
Fromto something else.@gvanrossum Would this weekly report be okay for typing-sig?
Cc @shannonzhu