feat: Add realtime collaboration #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been hidden.
This comment has been hidden.
gondar00
requested review from
Navaneeth-pk and
akshaysasidrn
and removed request for
Navaneeth-pk
- Add zindex to cursor such that query editor has precedence
|
@gondar00 please fix the lint errors. |
akshaysasidrn
previously approved these changes
Apr 19, 2022
|
@gondar00 LGTM, nice work. 👍🏾 |
|
@akshaysasidrn done |
akshaysasidrn
approved these changes
Apr 19, 2022
akshaysasidrn
added a commit
that referenced
this pull request
Apr 26, 2022
* [docs] replaced gif with intro video for the widget (#2797) Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> * Style updates for widget styles section of the widget inspector (#2757) * Ensure listItem is exposed for set/unset custom variables handler (#2813) * [docs] RethinkDB docs updated (#2809) * updating rethink docs * docs updates rethinkdb * updates header * Centered App Version in Editor (#2644) * Centered Text in App Version Manager dropdown * Centered Text in App Version Manager dropdown Fixes #2570 * resolved all comments * reverted package-lock * Updated widget names that were lowercase (#2817) * [docs] updated baserow and couchDB reference (#2816) * [docs] changed the s3 sidebar position from 20 to 1.1 (#2829) * Cypress test for login functionality (#2801) * Added cypress and other denpendencies * Added data-cy attribute for elements * Added cypress test for login functionality * Reverted unwanted files * Move documentation link in transformation popover to a new line (#2832) * Moved read documentation to new line * added period * Fixed the tooljet cli link in readme (#2833) * [Bugfix] On dispatching Undo ⌘Z or Redo ⌘+shift+Z actions to a component on the editor should also update the internal state or props for the children. (#2826) * fixes currentState should receive updates on appDefinations gets a new update [undo] * update the internal state or props for the children. * Improving codehinter UX for better typing (#2796) * checking keystroke for backspace and enter * cleanup * Set newGroupName to null on cancel (#2835) * Fix: set newGroupName to null on cancel * Fix: added comma * Add missing sourceOptions to Snowflake to fix the warehouse/database/schema/role when connecting (#2718) * Add missing sourceOptions to snowflake and use official snowflake-sdk * Revert change to snowflake-sdk * fix lint error * [ Feature ] :: svg widget (#2806) * svg icon * svg component * cleanup * name updated * name updated * fixing overflow issue * dafault image * [docs] renamed filepicker.md to file-picker.md (#2848) * Add count of elements to new datasource modal (#2846) * [Feature] Implemented SSL certificate option in PostgreSQL data-source (#2636) * working on ssl certificates * Implemented ssl ca certificate feature - Need to test other options too * Changed fields order * Changed cert fields to encrypted * [Bug-fix] Date picker dropdown breaks table row (#2803) * Solved a style issue * Solved the date picker issue * Solved table date picker ui issue * [ Feature ]:: Datepicker exlcudedates addition (#2751) * adding excluded dates property * updates :: writing date parse function * update parser * logic update * logic updated * reimplemented logic for excluded dates * typos updated * pr changes * pr changes * cleanup * docs updated * default value changed * cleanup * [Bugfix]: Allow firing onSearch event of Table widget irrespective of server-side search is set to true or false. (#2660) * resolves onsearch event for cliendside search * removes un-used props * Minor alignment for timeline title (#2849) * [docs] renamed deployment directory to Setup (#2847) * feat: Add realtime collaboration (#2517) * feat: add realtime collaboration * reduce delay in debounce * feat: add realtime cursors * feat: add realtime avatars * add current user to the online users list * add border color to the avatar * feat: allow multi user to edit multi-versions simultaneously * add getOne fn for fetching single api + avatar component * fix: set appDef from api call * replace webrtc with ws * move yjs to separate port (temp) * run on same port * fix: update ymap when styles have changed * - Add static list of colors - Show the username on hover * fix: cursors not showing up * fix: review comments * remove unused vars * add new cursor style * - Run yjs connection on a different path - Add zindex to cursor such that query editor has precedence * fix: event emitter bug + position bug * use shorthand * cursor style changes * fix cursor positions * inc zindex * change max avatars to 3 * [Bugfix] stripe query selection dropdown menu should display the selected component value on saving the query (#2106) * fixes should display selected component value on saving the query * handles undefined props to select component * fixes query failure and state update * removes log * fixes the crash * removes test files * fixes query options state: selected operation should display field on query save * fixes query options * fixes stripe query crash: on mount * adds remove params function * Update frontend/src/Editor/QueryManager/QueryEditors/Stripe.jsx resolves Co-authored-by: Gandharv <gandharvkumargarg@gmail.com> * resolves current value would lead to being a comma(,) * resolves current value would lead to being a comma(,) to null * resolves review changes * clean up: refactored Co-authored-by: Gandharv <gandharvkumargarg@gmail.com> * update label from URL to Base URL (#2859) * [docs] changed sidebar position for setup (#2858) * Fix inconsistent action button on share modal (#2854) * Feature: Add data transfer object layer to validate and sanitize user inputs (#2694) * add sanitize-html to be used with dto * add dto for controllers * add vaalidation to check token not empty * update test config * add validation pipe on test setup * fix spec * fix params casing * update dto for empt checks * update reset password dto * only check for options to be defined * update specs * update dto and spec * Remove invalid decorator * update package-lock * update thread dto * update user dto * fix email * make comment req params attributes as optional * fix specs * Followup to #2826 (#2870) * Fix user group not creating on press enter (#2869) - add onSubmit handler to form - made the name input a required field - removed the newGroup state(it's not being used) * Bugfix :: datepicker widget shows current date when default date is set as empty (#2875) * fixing default date bug * Set arbitrary default date for datepicker, and empty default exluded dates * If set date is invalid, ensure exposed value is undefined on Datepicker Co-authored-by: Sherfin Shamsudeen <sherfin94@gmail.com> * [ enhancement ] :: added on select event (#2707) * added on select event * docs updated * bugfix :: disable cursor when pagination icons are disabled (#2867) * [Feature] Added a feature to show maintenance state of an app (#2820) * Implmented toggle and confirmation modal - Also maintenance state will store in db as a global setting * Added is_maintenance_on column to apps table * Now maintenance state will store in app entity * Lauch btn will be disabled for on-maintenance apps * Users can't see preview using shared links when app is on maintenance * Changed toggle name * Changed maintenance dialog message - Changed button text - Fixed some alignment * Feature: added basic & bearer auth to Rest API (#2742) * Added basic and bearer auth fields * Implemented basic and bearer auth * Changed token name * Added encrpyted icon along side label * resolved a basic-auth bug * Refactored basic auth code * Fix: Thread/Comment edit and delete (#2880) * fix thread edit and delete * fix comment edit and delete * fix thread id type on entity * Add support to specify encoding on s3 upload operation Co-authored-by: shivangT <32157641+shivangT@users.noreply.github.com> Co-authored-by: Shivang Tiwari <shivangtiwari@Shivangs-MacBook-Pro.local> Co-authored-by: Kiran Ashok <stepinfwd@gmail.com> Co-authored-by: Sherfin Shamsudeen <sherfin94@gmail.com> Co-authored-by: KaviiSuri <surikavii@gmail.com> Co-authored-by: Mathías Donoso <mathiasd88@gmail.com> Co-authored-by: Shubhendra Singh Chauhan <withshubh@gmail.com> Co-authored-by: Manjunath <kadrimanjunath56@gmail.com> Co-authored-by: Ajith KV <ajith.jaban@gmail.com> Co-authored-by: Arpit <arpitnath42@gmail.com> Co-authored-by: Colton Almaraz <60356596+almaraz333@users.noreply.github.com> Co-authored-by: Josh Taylor <joshuataylorx@gmail.com> Co-authored-by: Dinath <88936472+DinahWorld@users.noreply.github.com> Co-authored-by: Eyuel Berga Woldemichael <30384633+eyuelberga@users.noreply.github.com> Co-authored-by: Muhsin Shah C P <muhsinshah21@gmail.com> Co-authored-by: Gandharv <gandharvkumargarg@gmail.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fixes: #2516