Conversation
frenck
reviewed
Mar 22, 2022
.github/workflows/verify.yml
Outdated
| CACHE_VERSION: 6 | ||
| DEFAULT_PYTHON: "3.9" | ||
| CACHE_VERSION: 7 | ||
| DEFAULT_PYTHON: "3.10" |
Contributor
There was a problem hiding this comment.
I won't recommend that, as this allows for sneaking in 3.10 features, that break 3.9 unexpectedly.
Member
Author
There was a problem hiding this comment.
Good call, just as much I'm not sure why it's breaking at black on 3.9 references now ... I'll look at it again with a fresh pair of eyes sometime later today.
frenck
reviewed
Mar 22, 2022
| needs: prepare-test-cache | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.9, "3.10"] |
Contributor
There was a problem hiding this comment.
Is the library removing 3.9 support?
Member
Author
There was a problem hiding this comment.
Just wanted to move default to 3.10 and still support 3.9 - as it's mainly focussed at HA we wouldn't drop until Core drops support
Contributor
There was a problem hiding this comment.
Its a matrix, there is no default :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.