New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve color consistency (save all labels) #19038
feat: improve color consistency (save all labels) #19038
Conversation
Co-authored-by: Geido <[email protected]>
…et into feat-color-consistency
|
/testenv up |
|
@jinghua-qa Ephemeral environment spinning up at http://54.190.44.153:8080. Credentials are |
|
Thank you for the fix! @stephenLYZ, i verified that the native filter issue has fixed. But i found another issue that when there is color scheme or customized label applied, if user open chart in explore, user will see warning that form data is lost and the color theme or label for the chart will be lost. Screen.Recording.2022-03-12.at.12.14.55.AM.mov |
|
@jinghua-qa It seems to be related to the recent |
|
@stephenLYZ I think I know what's the problem here. This PR changed the default cache type to |
|
I tested this PR locally, found another issue that, when applied native filter in different series of the same color, after filtered the it will still show same color of different series, is this acceptable? Screen.Recording.2022-03-15.at.9.37.38.PM.mov |
@jinghua-qa I think this is the expected behavior and objective of this PR. If you check before/after videos you'll see the same example. |
Executed the following test plan for color consistency and did not find major issues:
https://docs.google.com/spreadsheets/d/1W-sv4LM9XpRttHvMgL-FyWnjaftDGANx9jTCLVlKZUw/edit#gid=1323280743
LGTM!
|
@geido do you want to give this a final code pass? Sounds like we're about to have a beast of a problem behind us! |
|
Spinning up another test env. The previous one does not work for me |
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://54.218.201.167:8080. Credentials are |
|
Hello @stephenLYZ after testing an existing dashboard with a color scheme and no custom label colors, I found that some labels are not sharing the same colors even if they should? FCC.New.Coder.Survey.2018.mp4 |
|
@geido Nice catch! Fixed here. |
|
/testenv up |
|
@geido Ephemeral environment spinning up at http://50.112.38.121:8080. Credentials are |
|
@stephenLYZ I am worried that something happened to the ability to bring the colors of a chart from its Dashboard scheme to Explore. As you can see the colors in Explore look different from the Dashboard. untitled.dashboard.mp4 |
|
@geido Yes, it's a known issue and it only exists in the test environment, see Michael's comment. But in local env it cannot be reproduced.
|
|
Ephemeral environment shutdown and build artifacts deleted. |

SUMMARY
The difference between this PR and this one is that all label colors of the dashboard are saved to handle the native filter scenario.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-03-06.11.02.05.mov
after
2022-03-06.11.00.34.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION