Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recursive method for palindrome #455

Merged
merged 7 commits into from Dec 28, 2021

Conversation

nischal20
Copy link
Contributor

No description provided.

siriak
siriak previously approved these changes Dec 24, 2021
strings/palindrome/ispalindrome.go Outdated Show resolved Hide resolved
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
strings/palindrome/ispalindrome.go Outdated Show resolved Hide resolved
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the helper an unexported function. That is not useful/needed outside this package.

strings/palindrome/ispalindrome.go Outdated Show resolved Hide resolved
nischal20 and others added 2 commits December 27, 2021 12:48
Co-authored-by: Taj <tjgurwara99@users.noreply.github.com>
tjgurwara99
tjgurwara99 previously approved these changes Dec 27, 2021
Copy link
Member

@tjgurwara99 tjgurwara99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjgurwara99 tjgurwara99 enabled auto-merge (squash) December 27, 2021 18:12
auto-merge was automatically disabled December 27, 2021 19:01

Head branch was pushed to by a user without write access

siriak
siriak approved these changes Dec 28, 2021
@siriak siriak enabled auto-merge (squash) December 28, 2021 19:27
@siriak siriak merged commit b46d6da into TheAlgorithms:master Dec 28, 2021
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants