Simplify BreadthFirstSearch.go#465
Merged
siriak merged 1 commit intoTheAlgorithms:masterfrom Feb 5, 2022
Primital:patch-1
Merged
Simplify BreadthFirstSearch.go#465siriak merged 1 commit intoTheAlgorithms:masterfrom Primital:patch-1
siriak merged 1 commit intoTheAlgorithms:masterfrom
Primital:patch-1
Conversation
Remove redundant if clause which condition is always met at line of execution
Primital
requested review from
raklaptudirm,
siriak and
tjgurwara99
as code owners
tjgurwara99
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant if clause which condition is always met at line of execution
The condition of the for loop and the if clause are identical, so the condition of the if clause will always be met
I would suggest refactoring line 15,16 to
v, queue := queue[0], queue[1:]as well, but perhaps it is better to keep it simpler.